Skip to content

Fix #153942#153943

Closed
rec wants to merge 4 commits intogh/rec/148/basefrom
gh/rec/148/head
Closed

Fix #153942#153943
rec wants to merge 4 commits intogh/rec/148/basefrom
gh/rec/148/head

Conversation

@rec
Copy link
Collaborator

@rec rec commented May 20, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@rec
Update
5ec08d8 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153943

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8b4e532 with merge base 64f2ec7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@rec
Update
74250bc 
[ghstack-poisoned]
rec added a commit that referenced this pull request May 20, 2025
@rec
Fix #153942
a080618 
ghstack-source-id: 0af8725
Pull Request resolved: #153943
@rec rec added the topic: not user facing topic category label May 21, 2025
@rec
Update
fa271d8 
[ghstack-poisoned]
rec added a commit that referenced this pull request May 21, 2025
@rec
Fix #153942
7e974f3 
ghstack-source-id: a184102
Pull Request resolved: #153943
@rec rec marked this pull request as ready for review May 27, 2025 10:33
@rec rec requested review from Skylion007 and malfet May 27, 2025 10:33
@rec
Copy link
Collaborator Author

rec commented Jun 23, 2025

@malfet: any thoughts on this?

@rec
Update
8b4e532 
[ghstack-poisoned]
rec added a commit that referenced this pull request Jul 4, 2025
@rec
Fix #153942
a367093 
ghstack-source-id: b7c2029
Pull Request resolved: #153943
@rec
Copy link
Collaborator Author

rec commented Jul 4, 2025

@malfet, @Skylion007 : updated, what do you think?

malfet
malfet approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though I hope we can delete torch.deploy soon

@malfet
Copy link
Contributor

malfet commented Jul 4, 2025

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 4, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/rec/148/head branch August 4, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rec @malfet @pytorchmergebot @pytorchbot