[dynamo][compile-time] Faster inspect getattr_static for torch.Tensor#153522
Closed
anijain2305 wants to merge 4 commits intogh/anijain2305/768/basefrom
Closed
[dynamo][compile-time] Faster inspect getattr_static for torch.Tensor#153522anijain2305 wants to merge 4 commits intogh/anijain2305/768/basefrom
anijain2305 wants to merge 4 commits intogh/anijain2305/768/basefrom
Conversation
[ghstack-poisoned]
This was referenced May 14, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153522
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 9e4288b with merge base e0dece5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…orch.Tensor" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…orch.Tensor" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
StrongerXi
approved these changes
May 14, 2025
torch/_dynamo/variables/tensor.py
Outdated
| is_base_tensor_method = True | ||
| static_attr = all_tensor_attrs.get(name, None) | ||
| if static_attr is None: | ||
| is_base_tensor_method = False |
Contributor
There was a problem hiding this comment.
Maybe 1 liner?
is_base_tensor_method = static_attr is not None…orch.Tensor" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #153524 |
jansel
approved these changes
May 15, 2025
Collaborator
|
Starting merge as part of PR stack under #153524 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #153524 |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 15, 2025
Pull Request resolved: #153524 Approved by: https://github.com/StrongerXi, https://github.com/jansel ghstack dependencies: #153522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames