fix a bug when calling modules#1534
Merged
apaszke merged 1 commit intopytorch:masterfrom May 11, 2017
mdering:forwardfix
Merged
fix a bug when calling modules#1534apaszke merged 1 commit intopytorch:masterfrom mdering:forwardfix
apaszke merged 1 commit intopytorch:masterfrom
mdering:forwardfix
Conversation
a module that returns a non-standard data structure currently breaks due to checks for backwards hooks. This refactors the code slightly so this will only break in the event of backwards hooks.
Contributor
|
@pytorchbot test this please |
apaszke
approved these changes
May 11, 2017
Contributor
|
Thank you! |
zasdfgbnm
pushed a commit
to zasdfgbnm/pytorch
that referenced
this pull request
Mar 31, 2022
* Fixes validation of vectorization with contig indexing True contig indexing needs reference tensors, so finding vectorized contig domains at the initial validation time can result in false positives and negatives. Fixed by filling that information at the time of indexing. Also considered to keep it separated from indexing and fill it at the validation time, but it would end up replicating the same logic as reference replay. Closes pytorch#1534
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a module that returns a non-standard data structure currently breaks
due to checks for backwards hooks. This refactors the code slightly so
this will only break in the event of backwards hooks.