[dynamo][compile-time] Cache whether a function is inlineable#153192
Closed
anijain2305 wants to merge 8 commits intogh/anijain2305/759/basefrom
Closed
[dynamo][compile-time] Cache whether a function is inlineable#153192anijain2305 wants to merge 8 commits intogh/anijain2305/759/basefrom
anijain2305 wants to merge 8 commits intogh/anijain2305/759/basefrom
Conversation
[ghstack-poisoned]
This was referenced May 8, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153192
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit a5e1b2d with merge base 81719eb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ble" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…ble" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…ble" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
This was referenced May 12, 2025
…ble" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
StrongerXi
approved these changes
May 13, 2025
Comment on lines
-3791
to
-3801
| if isinstance(func, SkipFunctionVariable): | ||
| unimplemented_v2( | ||
| gb_type="Attempted to inline function marked as skipped (SkipFunctionVariable)", | ||
| context=f"Attempted to inline a SkipFunctionVariable {func}", | ||
| explanation="Attempted to inline a function that was previously determined to be marked as intentionally skipped.", | ||
| hints=[], | ||
| ) |
Contributor
There was a problem hiding this comment.
Curious why we moved this to below? Looks like SkipFunctionVariable will graph break both before and after this patch anyways?
jansel
approved these changes
May 13, 2025
williamwen42
approved these changes
May 13, 2025
| self.guards_context = GuardsContext() | ||
| self.module_context = ModuleContext() | ||
| self.global_context = GlobalContext() | ||
| self.previously_inlined_functions = dict() |
Member
There was a problem hiding this comment.
Would a weakref key'd dict be better here?
Contributor
Author
There was a problem hiding this comment.
Maybe. But the tracing context dies right after convert_frame is done, so we should not leak anything.
…ble" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…ble" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…ble" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames