Skip to content

[nativert] Address tooling setup for torch/nativert/#153164

Closed
zhxchen17 wants to merge 1 commit intopytorch:mainfrom
zhxchen17:export-D74407808
Closed

[nativert] Address tooling setup for torch/nativert/#153164
zhxchen17 wants to merge 1 commit intopytorch:mainfrom
zhxchen17:export-D74407808

Conversation

@zhxchen17
Copy link
Contributor

@zhxchen17 zhxchen17 commented May 8, 2025

Summary:
As discussed with @malfet , we're porting nativert code to torch/nativert/.
Following up some concerns over the new directory, I'm trying to setup the tooling on OSS so various things (like linters) can run on torch/nativert/ properly.

Test Plan: CI

Differential Revision: D74407808

@pytorch-bot
Copy link

pytorch-bot bot commented May 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153164

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2e014c9 with merge base 3cd6935 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 8, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74407808

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2025
@zhxchen17 zhxchen17 force-pushed the export-D74407808 branch from fa52a63 to 645c833 Compare May 8, 2025 17:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74407808

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74407808

Summary:
Pull Request resolved: pytorch#153164

As discussed with malfet, we're porting nativert code to torch/nativert/.
Following up some concerns over the new directory, I'm trying to setup the tooling on OSS so various things (like linters) can run on torch/nativert/ properly.

Test Plan: CI

Reviewed By: dolpm

Differential Revision: D74407808
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74407808

@zhxchen17 zhxchen17 force-pushed the export-D74407808 branch from 19f45bf to 2e014c9 Compare May 8, 2025 17:25
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants