[dynamo] Fix bug in hasattr(tensor, "size") by anijain2305 · Pull Request #152883 · pytorch/pytorch

anijain2305 · 2025-05-06T00:04:07Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[ghstack-poisoned]

pytorch-bot · 2025-05-06T00:04:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152883

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 3b34ddf with merge base f5f8f63 ():

CANCELLED JOB - The following job was cancelled. Please retry:

pull / linux-jammy-xpu-2025.0-py3.9 / build (gh)
##[error]The operation was canceled.

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, ephemeral.linux.g5.4xlarge.nvidia.gpu) (gh) (#152916)
[ FAILED ] AotInductorTest.BasicTestCuda

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 4fec632 Pull Request resolved: #152883

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 56a0778 Pull Request resolved: #152883

torch/_dynamo/variables/tensor.py

Fixes #135696 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

ghstack-source-id: 317cf95 Pull Request resolved: #152883

StrongerXi · 2025-05-07T21:09:35Z

torch/_dynamo/variables/tensor.py

+        if name in ("size", "stride"):
+            return ConstantVariable(True)


Without this, do we always end up getting ret_val = False below or something?

Yes. See the test! Such an embarrassing failure.

We basically go into this ret_val = not isinstance(var, GetAttrVariable)

But the thing is that it is a valid attribute. For some complicated unknown reason, we have GetAttrVariable for both existent and non-existent attributes.

anijain2305 · 2025-05-07T21:35:28Z

@pytorchbot merge

pytorchmergebot · 2025-05-07T21:38:39Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-05-07T23:45:02Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-xpu-2025.0-py3.9 / build

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

anijain2305 · 2025-05-08T01:08:32Z

@pytorchbot merge -i

pytorchmergebot · 2025-05-08T01:10:26Z

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-xpu-2025.0-py3.9 / build, inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, ephemeral.linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: #153105 Approved by: https://github.com/jansel ghstack dependencies: #152883

…ing (#153159) Pull Request resolved: #153159 Approved by: https://github.com/laithsakka ghstack dependencies: #152883, #153105

[dynamo] Fix bug in hasattr(tensor, "size")

184dc80

[ghstack-poisoned]

anijain2305 mentioned this pull request May 6, 2025

[dynamo] Recursively realize the stack_values #152853

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels May 6, 2025

anijain2305 added a commit that referenced this pull request May 6, 2025

[dynamo] Fix bug in hasattr(tensor, "size")

7f27ed1

ghstack-source-id: 4fec632 Pull Request resolved: #152883

Update on "[dynamo] Fix bug in hasattr(tensor, "size")"

11702b1

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Update on "[dynamo] Fix bug in hasattr(tensor, "size")"

7074407

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Update on "[dynamo] Fix bug in hasattr(tensor, "size")"

8c05847

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

anijain2305 added the keep-going Don't stop on first failure, keep running tests until the end label May 6, 2025

anijain2305 added a commit that referenced this pull request May 6, 2025

[dynamo] Fix bug in hasattr(tensor, "size")

1282fbb

ghstack-source-id: 56a0778 Pull Request resolved: #152883

anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels May 6, 2025

Skylion007 reviewed May 7, 2025

View reviewed changes

torch/_dynamo/variables/tensor.py Outdated Show resolved Hide resolved

Update on "[dynamo] Fix bug in hasattr(tensor, "size")"

33eea06

Fixes #135696 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

Update on "[dynamo] Fix bug in hasattr(tensor, "size")"

3b34ddf

Fixes #135696 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

anijain2305 added a commit that referenced this pull request May 7, 2025

[dynamo] Fix bug in hasattr(tensor, "size")

25a0edd

ghstack-source-id: 317cf95 Pull Request resolved: #152883

anijain2305 requested a review from StrongerXi May 7, 2025 20:56

StrongerXi approved these changes May 7, 2025

View reviewed changes

pytorchmergebot added the merging label May 7, 2025

anijain2305 mentioned this pull request May 7, 2025

[dynamo] Fix super and classmethod binding of cls object #153105

Closed

pytorchmergebot removed the merging label May 7, 2025

pytorchmergebot added the merging label May 8, 2025

pytorchmergebot added the Merged label May 8, 2025

pytorchmergebot closed this in 6f6fac6 May 8, 2025

pytorchmergebot removed the merging label May 8, 2025

pytorchmergebot pushed a commit that referenced this pull request May 8, 2025

[dynamo] Fix super and classmethod binding of cls object (#153105)

34d4363

Pull Request resolved: #153105 Approved by: https://github.com/jansel ghstack dependencies: #152883

This was referenced May 8, 2025

[dynamo][pr_time_benchmark] Add dynamo benchmark to stress test inlining #153159

Closed

[dynamo][compile time optimization] Caching some hot spots #153191

Closed

[dynamo][compile-time] Cache whether a function is inlineable #153192

Closed

pytorchmergebot pushed a commit that referenced this pull request May 9, 2025

[dynamo][pr_time_benchmark] Add dynamo benchmark to stress test inlin…

ab829ec

…ing (#153159) Pull Request resolved: #153159 Approved by: https://github.com/laithsakka ghstack dependencies: #152883, #153105

This was referenced May 9, 2025

[dynamo][refactor] bytecode transform callable to return optimized instructions #153292

Closed

[dynamo] Move propagate_line_nums in cleaned_instructions #153293

Closed

github-actions bot deleted the gh/anijain2305/755/head branch June 17, 2025 02:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dynamo] Fix bug in hasattr(tensor, "size")#152883

[dynamo] Fix bug in hasattr(tensor, "size")#152883
anijain2305 wants to merge 6 commits intogh/anijain2305/755/basefrom
gh/anijain2305/755/head

anijain2305 commented May 6, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented May 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

StrongerXi May 7, 2025

Uh oh!

anijain2305 May 7, 2025

Uh oh!

anijain2305 May 7, 2025 •

edited

Loading

Uh oh!

anijain2305 commented May 7, 2025

Uh oh!

pytorchmergebot commented May 7, 2025

Uh oh!

pytorchmergebot commented May 7, 2025

Uh oh!

anijain2305 commented May 8, 2025

Uh oh!

pytorchmergebot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

anijain2305 commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152883

❌ 1 Cancelled Job, 1 Unrelated Failure

Uh oh!

Uh oh!

StrongerXi May 7, 2025

Choose a reason for hiding this comment

Uh oh!

anijain2305 May 7, 2025

Choose a reason for hiding this comment

Uh oh!

anijain2305 May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anijain2305 commented May 7, 2025

Uh oh!

pytorchmergebot commented May 7, 2025

Merge started

Uh oh!

pytorchmergebot commented May 7, 2025

Merge failed

Uh oh!

anijain2305 commented May 8, 2025

Uh oh!

pytorchmergebot commented May 8, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anijain2305 commented May 6, 2025 •

edited

Loading

pytorch-bot bot commented May 6, 2025 •

edited

Loading

anijain2305 May 7, 2025 •

edited

Loading