Skip to content

[TEST][Quantization] Skip test_learnable due to hypothesis#152819

Closed
Aidyn-A wants to merge 1 commit intopytorch:mainfrom
Aidyn-A:skip_test_learnable_per_channel_cuda
Closed

[TEST][Quantization] Skip test_learnable due to hypothesis#152819
Aidyn-A wants to merge 1 commit intopytorch:mainfrom
Aidyn-A:skip_test_learnable_per_channel_cuda

Conversation

@Aidyn-A
Copy link
Collaborator

@Aidyn-A Aidyn-A commented May 5, 2025

As per comment in #111471 (comment) the tests are failing due to hypothesis. This PR adds a skip to those tests.

@Aidyn-A Aidyn-A requested a review from jerryzh168 as a code owner May 5, 2025 11:51
@pytorch-bot
Copy link

pytorch-bot bot commented May 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152819

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 4c81f96 with merge base 7368eeb (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: quantization release notes category topic: not user facing topic category labels May 5, 2025
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 6, 2025
@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented May 7, 2025

@jerryzh168 can you please opine?

Copy link
Collaborator

@eqy eqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe consider setting as xFail

@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented May 31, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased skip_test_learnable_per_channel_cuda onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skip_test_learnable_per_channel_cuda && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the skip_test_learnable_per_channel_cuda branch from f53ad72 to 4c81f96 Compare May 31, 2025 17:37
@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Jun 3, 2025

nit: maybe consider setting as xFail

The surrounding tests that are failing because of hypothesis were skipped. So I am skipping these one too.

@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Jun 3, 2025

CI test failures are unrelated.

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 3, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3-clang12-executorch / build, pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull request Jun 4, 2025
…52819)

As per comment in pytorch#111471 (comment) the tests are failing due to hypothesis. This PR adds a skip to those tests.
Pull Request resolved: pytorch#152819
Approved by: https://github.com/eqy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: quantization release notes category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants