[inductor] propagate shapes in CSEVariable#152198
[inductor] propagate shapes in CSEVariable#152198isuruf wants to merge 21 commits intogh/isuruf/141/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152198
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 006a0e1 with merge base 1795116 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rec
left a comment
There was a problem hiding this comment.
Sorry, quick unsolicited review while waiting for something else, feel free to ignore!
🙂
torch/_inductor/codegen/common.py
Outdated
| write: bool = True, | ||
| assignment: bool = True, | ||
| dtype: Optional[torch.dtype] = None, | ||
| shape: Optional[ShapeType] = None, |
There was a problem hiding this comment.
Does it have to be Optional here, either? Couldn't the default be ()?
It makes the code simpler if you're not always checking for None.
There was a problem hiding this comment.
() means the variable is a scalar. None means we don't know.
[ghstack-poisoned]
|
Possible to land this soon ? |
|
Yes, let's land this soon. The only holdover is your comment
Do you mean removing the changes in |
|
Per your comment
we're not actually changing codegen yet. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable), trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m1-14) Details for Dev Infra teamRaised by workflow job |
[ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
torch._inductor.virtualized.OpsValue objects instance does not have shape attribute. This breaks the fp8 test on ROCm. Add the OpsValue class in todo list. Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>
torch._inductor.virtualized.OpsValue objects instance does not have shape attribute. This breaks the fp8 test on ROCm. Add the OpsValue class in todo list. Pull Request resolved: #161166 Approved by: https://github.com/jeffdaily
Fixes pytorch#149905 Pull Request resolved: pytorch#152198 Approved by: https://github.com/eellison
torch._inductor.virtualized.OpsValue objects instance does not have shape attribute. This breaks the fp8 test on ROCm. Add the OpsValue class in todo list. Pull Request resolved: pytorch#161166 Approved by: https://github.com/jeffdaily
Stack from ghstack (oldest at bottom):
Fixes #149905
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben