Fix memory leak in THCSTensor_spcadd.#1519
Merged
soumith merged 1 commit intopytorch:masterfrom May 15, 2017
Merged
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
|
can you fix that unnecessary freeCopyTo as well? |
Contributor
Author
|
Yes, working on it :) |
soumith
approved these changes
May 15, 2017
jjsjann123
added a commit
to jjsjann123/pytorch
that referenced
this pull request
Mar 21, 2022
Fixes pytorch#1514 Issue arises when we try to collapse a dimension to a broadcasted dimension. PyTorch mark all dimension with stride 1 to be contiguous. This used to be fine until recently we changed it that broadcasted dimension with stride 0 can now be put as a faster dimension. So now we can be collapsing a normal dimension into a broadcasted dimension and our index is wrong, since broadcasted dimension has stride 0. The solution is to explicitly check inner dimension stride for contiguous dimension and only collapse when inner dimension is not broadcasted.
jagadish-amd
pushed a commit
to jagadish-amd/pytorch
that referenced
this pull request
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Z. Yang ezyang@fb.com