[BE] Upgrade XPU support package to 2025.1 in CICD#151899
Closed
chuanqi129 wants to merge 1 commit intopytorch:mainfrom
Closed
[BE] Upgrade XPU support package to 2025.1 in CICD#151899chuanqi129 wants to merge 1 commit intopytorch:mainfrom
chuanqi129 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151899
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit e5ac494 with merge base 032ef48 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 22, 2025
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the XPU support package to version 2025.1 across various CICD configurations. Key changes include:
- Updating Linux and Windows build and test workflows to reference XPU 2025.1.
- Revising PYTORCH_EXTRA_INSTALL_REQUIREMENTS in multiple workflows to use version 2025.1.1.
- Removing deprecated support package version docker image build entries.
Reviewed Changes
Copilot reviewed 6 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/xpu.yml | Updated job identifiers, environment variables, and sync tags to use XPU 2025.1 specifications. |
| .github/workflows/pull.yml | Updated workflow job names and sync-tag for XPU builds; minor inconsistencies remain in build params. |
| .github/workflows/generated-windows-binary-wheel-nightly.yml | Revised extra install requirements to incorporate the new XPU package version for Windows CI. |
| .github/workflows/generated-linux-binary-manywheel-nightly.yml | Revised extra install requirements to incorporate the new XPU package version for Linux manywheel CI. |
| .github/workflows/docker-builds.yml | Replaced deprecated docker image build entry with the updated XPU version. |
| .github/scripts/generate_binary_build_matrix.py | Updated build matrix strings to reference the new XPU package version. |
Files not reviewed (8)
- .ci/docker/build.sh: Language not supported
- .ci/docker/common/install_xpu.sh: Language not supported
- .ci/docker/manywheel/Dockerfile_2_28: Language not supported
- .ci/manywheel/build_xpu.sh: Language not supported
- .ci/pytorch/windows/internal/xpu_install.bat: Language not supported
- .ci/pytorch/windows/xpu.bat: Language not supported
- .circleci/scripts/binary_windows_build.sh: Language not supported
- .circleci/scripts/binary_windows_test.sh: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/pull.yml:541
- The build-environment is still set to linux-jammy-xpu-2025.0-py3.9; please update it to linux-jammy-xpu-2025.1-py3.9 for consistency with the new support package version.
build-environment: linux-jammy-xpu-2025.0-py3.9
.github/workflows/pull.yml:542
- The docker-image-name is still referencing version 2025.0; please update it to ci-image:pytorch-linux-jammy-xpu-2025.1-py3 to match the intended upgrade.
docker-image-name: ci-image:pytorch-linux-jammy-xpu-2025.0-py3
EikanWang
approved these changes
May 12, 2025
Comment on lines
+95
to
+97
| "oneccl-devel==2021.15.1; platform_system == 'Linux' and platform_machine == 'x86_64' | " | ||
| "oneccl==2021.15.1; platform_system == 'Linux' and platform_machine == 'x86_64' | " | ||
| "impi-rt==2021.15.0; platform_system == 'Linux' and platform_machine == 'x86_64' | " |
Collaborator
There was a problem hiding this comment.
For reviewers' information - the three packages are dedicated to Intel Communication Collective Libraries for Distributed. Currently, Intel GPU only plans to support Linux.
Contributor
|
@pytorchmergebot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
atalman
pushed a commit
to pytorch/test-infra
that referenced
this pull request
May 14, 2025
github-merge-queue bot
pushed a commit
to intel/torch-xpu-ops
that referenced
this pull request
May 16, 2025
PyTorch related PR: pytorch/pytorch#151899 --------- Co-authored-by: mengfeil <test>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #151097. Including below changes,