Fix score_mod.py dynamic max autotune for backward#151270
Closed
fegin wants to merge 2 commits intogh/fegin/298/basefrom
Closed
Fix score_mod.py dynamic max autotune for backward#151270fegin wants to merge 2 commits intogh/fegin/298/basefrom
fegin wants to merge 2 commits intogh/fegin/298/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151270
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8b25c08 with merge base c9aef50 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
fegin
added a commit
to pytorch/torchtitan
that referenced
this pull request
Apr 16, 2025
Implement iRoPE for llama4 Needs the fix from PyTorch: pytorch/pytorch#151270
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Same as pytorch#148991 but this PR fixes the backward path. Pull Request resolved: pytorch#151270 Approved by: https://github.com/drisspg, https://github.com/bobrenjc93
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Same as pytorch#148991 but this PR fixes the backward path. Pull Request resolved: pytorch#151270 Approved by: https://github.com/drisspg, https://github.com/bobrenjc93
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 13, 2026
Implement iRoPE for llama4 Needs the fix from PyTorch: pytorch/pytorch#151270
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 25, 2026
Implement iRoPE for llama4 Needs the fix from PyTorch: pytorch/pytorch#151270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Same as #148991 but this PR fixes the backward path.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov