Raise `BufferError` for DLPack buffer-related errors. by ysiraichi · Pull Request #150691 · pytorch/pytorch

ysiraichi · 2025-04-04T18:00:33Z

Stack from ghstack (oldest at bottom):

This PR addresses the Array API documentation for __dlpack__ and
from_dlpack by making some buffer-related errors BufferError
instead of RuntimeError, e.g. incompatible dtype, strides, or device.

[ghstack-poisoned]

pytorch-bot · 2025-04-04T18:00:37Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150691

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 46f6ffc with merge base 7cc1a95 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: fc97736 Pull Request resolved: #150691

[ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: c3b89e9 Pull Request resolved: #150691

[ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: bca99f7 Pull Request resolved: #150691

msaroufim · 2025-05-14T05:03:47Z

aten/src/ATen/DLConvertor.cpp

    case ScalarType::Float8_e4m3fnuz:
    case ScalarType::Float8_e8m0fnu:
-      TORCH_CHECK(false, "float8 types are not supported by dlpack");
+      TORCH_CHECK_BUFFER(false, "float8 types are not supported by dlpack");


maybe the more specific error would be not supported by 1.0, it is supported for example by 1.1 now https://github.com/dmlc/dlpack/releases

Curious to hear your reasoning for why we shouldn't just upgrade to 1.1

Sure we could do that. But, maybe in a later PR.

[ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: 6914afe Pull Request resolved: #150691

[ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: e424099 Pull Request resolved: #150691

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack [ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: 335dac1 Pull Request resolved: #150691

ysiraichi · 2025-06-14T17:44:18Z

@albanD I think I have addressed all of the reviews.
Could you take a look at this stack of PRs, again?

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack [ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: 21bc769 Pull Request resolved: #150691

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack [ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: e21030d Pull Request resolved: #150691

ysiraichi · 2025-07-12T13:33:00Z

@pytorchbot merge

pytorchmergebot · 2025-07-12T13:34:57Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-07-12T15:09:49Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team

Raised by workflow job

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack [ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: 31c28de Pull Request resolved: #150691

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack [ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: a4b20b7 Pull Request resolved: #150691

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack [ghstack-poisoned]

This PR addresses the Array API documentation for [`__dlpack__`][1] and [`from_dlpack`][2] by making some buffer-related errors `BufferError` instead of `RuntimeError`, e.g. incompatible dtype, strides, or device. [1]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__dlpack__.html [2]: https://data-apis.org/array-api/latest/API_specification/generated/array_api.from_dlpack.html#from-dlpack ghstack-source-id: 1ba90aa Pull Request resolved: #150691

ysiraichi · 2025-07-19T20:46:17Z

@pytorchbot merge

pytorchmergebot · 2025-07-19T20:48:25Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Update

121d64f

[ghstack-poisoned]

This was referenced Apr 4, 2025

Upgrade to DLPack 1.0. #145000

Closed

[DLPack] add NumPy exchange tests. #150216

Closed

This was referenced Apr 4, 2025

Fix DLPack stream logic. #150217

Closed

[DLPack] Add support for missing keyword-arguments. #150218

Closed

ysiraichi added module: dlpack release notes: python_frontend python frontend release notes category labels Apr 4, 2025

pytorchbot added the open source label Apr 4, 2025

Update

a309dd1

[ghstack-poisoned]

Skylion007 approved these changes Apr 8, 2025

View reviewed changes

Update

8e6ee74

[ghstack-poisoned]

Update

363fa7a

[ghstack-poisoned]

ysiraichi requested review from albanD and rgommers April 25, 2025 23:34

Update

c25232c

[ghstack-poisoned]

msaroufim reviewed May 14, 2025

View reviewed changes

albanD approved these changes May 14, 2025

View reviewed changes

Update

fdcd11c

[ghstack-poisoned]

Rebased.

e740e3f

[ghstack-poisoned]

Update

31f2b71

[ghstack-poisoned]

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 12, 2025

pytorchmergebot added the merging label Jul 12, 2025

pytorchmergebot removed the merging label Jul 12, 2025

pytorchmergebot added the merging label Jul 19, 2025

pytorchmergebot added the Merged label Jul 20, 2025

pytorchmergebot closed this in b4abf41 Jul 20, 2025

pytorchmergebot removed the merging label Jul 20, 2025

github-actions bot deleted the gh/ysiraichi/87/head branch August 19, 2025 02:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raise `BufferError` for DLPack buffer-related errors.#150691

Raise `BufferError` for DLPack buffer-related errors.#150691
ysiraichi wants to merge 17 commits intogh/ysiraichi/87/basefrom
gh/ysiraichi/87/head

ysiraichi commented Apr 4, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Apr 4, 2025 •

edited

Loading

Uh oh!

msaroufim May 14, 2025 •

edited

Loading

Uh oh!

ysiraichi May 24, 2025

Uh oh!

ysiraichi commented Jun 14, 2025

Uh oh!

ysiraichi commented Jul 12, 2025

Uh oh!

pytorchmergebot commented Jul 12, 2025

Uh oh!

pytorchmergebot commented Jul 12, 2025

Uh oh!

ysiraichi commented Jul 19, 2025

Uh oh!

pytorchmergebot commented Jul 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ysiraichi commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150691

✅ No Failures

Uh oh!

msaroufim May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ysiraichi May 24, 2025

Choose a reason for hiding this comment

Uh oh!

ysiraichi commented Jun 14, 2025

Uh oh!

ysiraichi commented Jul 12, 2025

Uh oh!

pytorchmergebot commented Jul 12, 2025

Merge started

Uh oh!

pytorchmergebot commented Jul 12, 2025

Merge failed

Uh oh!

ysiraichi commented Jul 19, 2025

Uh oh!

pytorchmergebot commented Jul 19, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ysiraichi commented Apr 4, 2025 •

edited

Loading

pytorch-bot bot commented Apr 4, 2025 •

edited

Loading

msaroufim May 14, 2025 •

edited

Loading