add batching rule for torch.Tensor.scatter_add_#150543
Closed
guilhermeleobas wants to merge 4 commits intogh/guilhermeleobas/117/basefrom
Closed
add batching rule for torch.Tensor.scatter_add_#150543guilhermeleobas wants to merge 4 commits intogh/guilhermeleobas/117/basefrom
torch.Tensor.scatter_add_#150543guilhermeleobas wants to merge 4 commits intogh/guilhermeleobas/117/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150543
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3311987 with merge base 3da14d3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
reviewed
Apr 7, 2025
| int64_t dim, | ||
| const Tensor& index, std::optional<int64_t> index_bdim, | ||
| const Tensor& src, std::optional<int64_t> src_bdim) { | ||
| auto self_ = self.clone(at::MemoryFormat::Preserve); |
Contributor
There was a problem hiding this comment.
why do we need the clone now?
zou3519
approved these changes
Apr 7, 2025
Collaborator
Author
|
@pytorchbot merge -r |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
|
Successfully rebased |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: pytorch#150543 Approved by: https://github.com/zou3519
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150543 Approved by: https://github.com/zou3519
frgossen
added a commit
that referenced
this pull request
Mar 11, 2026
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 12, 2026
The underlying bug (eager vs AOTDispatcher output mismatch for as_strided_scatter) was fixed by #150543. Remove the stale skip. Closes #85879 Pull Request resolved: #177203 Approved by: https://github.com/aorenste, https://github.com/zou3519
EmanueleCoradin
pushed a commit
to EmanueleCoradin/pytorch
that referenced
this pull request
Mar 30, 2026
…77203) The underlying bug (eager vs AOTDispatcher output mismatch for as_strided_scatter) was fixed by pytorch#150543. Remove the stale skip. Closes pytorch#85879 Pull Request resolved: pytorch#177203 Approved by: https://github.com/aorenste, https://github.com/zou3519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
torch.Tensor.scatter_add_#150543cc @zou3519 @Chillee @samdow @kshitij12345