Add option to define OpenBLAS version for manylinux Dockerfile_2_28_aarch64#150106
Add option to define OpenBLAS version for manylinux Dockerfile_2_28_aarch64#150106davsva01 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150106
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 4700d8e with merge base 28cb3c0 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "ciflow/linux-aarch64" |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@pytorchbot label "module: arm" |
There was a problem hiding this comment.
The downside of this PR is that when we need to update the OpenBLAS version, we now have to (remember to) change the version in 2 scripts (.ci/docker/common/install_openblas.sh and .ci/docker/manywheel/build.sh) instead of just 1.
Is it possible to make sure that the version is only set/hardcoded in one place?
We currently have this problem of having to update multiple scripts on a version change in ACL. The price we paid for that was having ACL version in manylinux ahead of that in CI, leading to green CI, but having test failures with manylinux builds
You mean remove the |
Yeah, having the version hard-coded in just one place. |
37a0d91 to
806d87a
Compare
Currently the only image using |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
CI failure is unrelated |
|
@pytorchbot merge |
|
@pytorchbot rebase |
@malfet this seems unrelated, would it be acceptable for me to force-merge here? |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
3141748 to
22ade68
Compare
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
22ade68 to
17dbdc4
Compare
|
@pytorchbot merge -h |
PyTorchBot HelpMergeRevertRebaseLabelDr CIcherry-pickCloseusage: @pytorchbot close Close a PR [Can be used on issues] |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
…arch64 Adds optional variable OPENBLAS_VERSION to .ci/docker/common/install_openblas.sh used to define which version of OpenBLAS to install. Adds argument to Dockerfile_2_28_aarch64 image.
Co-authored-by: Fadi Arafeh <115173828+fadara01@users.noreply.github.com>
|
Successfully rebased |
17dbdc4 to
4700d8e
Compare
|
failures are unrelated. |
Merge startedYour change will be merged while ignoring the following 4 checks: Build manywheel docker images for s390x / build-docker-cpu-s390x, docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-py3-clang12-executorch), pull / linux-jammy-py3-clang12-executorch / build, pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…arch64 (pytorch#150106) Adds optional variable OPENBLAS_VERSION to `.ci/docker/common/install_openblas.sh` used to define which version of OpenBLAS to install. Adds argument to `Dockerfile_2_28_aarch64` image. Pull Request resolved: pytorch#150106 Approved by: https://github.com/aditew01, https://github.com/fadara01, https://github.com/malfet Co-authored-by: Fadi Arafeh <115173828+fadara01@users.noreply.github.com>
…arch64 (pytorch#150106) Adds optional variable OPENBLAS_VERSION to `.ci/docker/common/install_openblas.sh` used to define which version of OpenBLAS to install. Adds argument to `Dockerfile_2_28_aarch64` image. Pull Request resolved: pytorch#150106 Approved by: https://github.com/aditew01, https://github.com/fadara01, https://github.com/malfet Co-authored-by: Fadi Arafeh <115173828+fadara01@users.noreply.github.com>
Adds optional variable OPENBLAS_VERSION to
.ci/docker/common/install_openblas.shused to define which version of OpenBLAS to install. Adds argument toDockerfile_2_28_aarch64image.cc @malfet @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01