Skip to content

Improve error message for torch.fft.ihfft2 when input's dtype is complex#149692

Closed
shink wants to merge 2 commits intopytorch:mainfrom
shink:fix/errormessage/fft
Closed

Improve error message for torch.fft.ihfft2 when input's dtype is complex#149692
shink wants to merge 2 commits intopytorch:mainfrom
shink:fix/errormessage/fft

Conversation

@shink
Copy link
Contributor

@shink shink commented Mar 21, 2025

Fixes #149625

For the case mentioned in the issue, will get:

RuntimeError: Only supports floating-point dtypes, but found: ComplexDouble

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149692

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1192c9b with merge base 28cb3c0 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@shink shink changed the title Improve error message for torch.fft.rfft2 when Improve error message for torch.fft.rfft2 when input's dtype is complex Mar 21, 2025
@shink shink changed the title Improve error message for torch.fft.rfft2 when input's dtype is complex Improve error message for torch.fft.ihfft2 when input's dtype is complex Mar 21, 2025
@shink
Copy link
Contributor Author

shink commented Mar 21, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 21, 2025
@bdhirsh bdhirsh requested a review from malfet March 24, 2025 14:31
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 24, 2025
@shink
Copy link
Contributor Author

shink commented Apr 4, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/errormessage/fft onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/errormessage/fft && git pull --rebase)

@shink
Copy link
Contributor Author

shink commented Jun 3, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/errormessage/fft onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/errormessage/fft && git pull --rebase)

@shink
Copy link
Contributor Author

shink commented Jun 3, 2025

@malfet Could you please help review this? Thanks!

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for updating error message

@malfet
Copy link
Contributor

malfet commented Jun 3, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 3, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull request Jun 4, 2025
…mplex (pytorch#149692)

Fixes pytorch#149625

For the case mentioned in the issue, will get:

```
RuntimeError: Only supports floating-point dtypes, but found: ComplexDouble
```

Pull Request resolved: pytorch#149692
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Improve Error Message Bugs

5 participants