[ROCm] skip test_RNN_dropout_state#149446
Closed
dnikolaev-amd wants to merge 2 commits intopytorch:mainfrom
Closed
[ROCm] skip test_RNN_dropout_state#149446dnikolaev-amd wants to merge 2 commits intopytorch:mainfrom
dnikolaev-amd wants to merge 2 commits intopytorch:mainfrom
Conversation
Currently ROCm doesn't support dropout value for RNN PR to enable RNN dropout on ROCm still in review pytorch#144572
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149446
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit e1c2915 with merge base d80a70b ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pruthvistony
approved these changes
Mar 20, 2025
jeffdaily
approved these changes
Mar 20, 2025
Collaborator
|
@pytorchbot merge -f "Unrelated lint errors. Simple skip for UT" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
PR to skip test_nn.py::TestNN::test_RNN_dropout_state Currently ROCm doesn't support dropout value for RNN PR to enable RNN dropout on ROCm still in review and blocked pytorch#144572 Fixes: pytorch#68849 Pull Request resolved: pytorch#149446 Approved by: https://github.com/pruthvistony, https://github.com/jeffdaily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to skip test_nn.py::TestNN::test_RNN_dropout_state
Currently ROCm doesn't support dropout value for RNN
PR to enable RNN dropout on ROCm still in review and blocked #144572
Fixes: #68849
cc: @jithunnair-amd @pruthvistony
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd