Remove backend_type_map from Backend#147635
Closed
H-Huang wants to merge 1 commit intogh/H-Huang/168/basefrom
Closed
Remove backend_type_map from Backend#147635H-Huang wants to merge 1 commit intogh/H-Huang/168/basefrom
H-Huang wants to merge 1 commit intogh/H-Huang/168/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147635
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit e9fe4a0 with merge base a8ce4d1 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
reviewed
Feb 26, 2025
| group_rank, | ||
| group_size, | ||
| ) | ||
| # Set the default backend when only single backend is passed in. |
Contributor
There was a problem hiding this comment.
Hmm can we remove this default backend logic without breaking BC?
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fix #147044.
backend_type_mapwas previously used to get the default device for the object collectives / barrier, but is no longer used, so we can remove it. Not sure if this will break anything in our tests, so waiting for CI to run.cc @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o