Don't truncate to index type in scatter/gather kernels#1469
Closed
killeent wants to merge 2 commits intopytorch:masterfrom
Closed
Don't truncate to index type in scatter/gather kernels#1469killeent wants to merge 2 commits intopytorch:masterfrom
killeent wants to merge 2 commits intopytorch:masterfrom
Conversation
apaszke
reviewed
May 4, 2017
| src, &srcOffset); | ||
|
|
||
| IndexType indexValue = (IndexType)index.data[indexOffset] - TH_INDEX_BASE; | ||
| long indexValue = index.data[indexOffset] - TH_INDEX_BASE; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
May 8, 2017
soumith
approved these changes
May 8, 2017
Collaborator
|
this is now merged into master |
zasdfgbnm
pushed a commit
to zasdfgbnm/pytorch
that referenced
this pull request
Feb 22, 2022
Fixes pytorch#1466 Note that this is a WAR, not a proper fix on codegen to handle size-0
jagadish-amd
pushed a commit
to jagadish-amd/pytorch
that referenced
this pull request
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan: ran test for scatter/gather