Skip to content

[ROCm] Tune 3d tensor sums when not using fastest dimension#146170

Closed
doru1004 wants to merge 1 commit intopytorch:mainfrom
doru1004:tune-3d-tensor-sum-upstream
Closed

[ROCm] Tune 3d tensor sums when not using fastest dimension#146170
doru1004 wants to merge 1 commit intopytorch:mainfrom
doru1004:tune-3d-tensor-sum-upstream

Conversation

@doru1004
Copy link
Contributor

@doru1004 doru1004 commented Jan 31, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146170

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit de38353 with merge base 550441a (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch release notes: cuda release notes category labels Jan 31, 2025
@pruthvistony pruthvistony added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR rocm This tag is for PRs from ROCm team ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm topic: not user facing topic category and removed release notes: cuda release notes category labels Jan 31, 2025
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:48 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:48 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:48 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:48 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:48 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:48 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:49 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:49 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:49 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:49 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 17:49 Inactive
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 31, 2025
@doru1004
Copy link
Contributor Author

doru1004 commented Feb 3, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased tune-3d-tensor-sum-upstream onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout tune-3d-tensor-sum-upstream && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the tune-3d-tensor-sum-upstream branch from bb2488d to de38353 Compare February 3, 2025 19:05
@jerrymannil
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 4, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jerrymannil pushed a commit to ROCm/pytorch that referenced this pull request Feb 6, 2025
…146170)

Tune 3d tensor sums when not using fastest dimension.

Pull Request resolved: pytorch#146170
Approved by: https://github.com/jeffdaily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source rocm This tag is for PRs from ROCm team topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants