Add istft option to align window for center = false#145510
Closed
jackzhxng wants to merge 31 commits intojz/stft-old-fcfrom
Closed
Add istft option to align window for center = false#145510jackzhxng wants to merge 31 commits intojz/stft-old-fcfrom
jackzhxng wants to merge 31 commits intojz/stft-old-fcfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145510
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9a95de9 with merge base b2c89bc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 23, 2025
Skylion007
reviewed
Jan 23, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 30, 2025
Long overdue follow-up on https://github.com/pytorch/pytorch/pull/73432/files#diff-5f3d4caa0693a716fc46fd7f6339312f1b5f0bf89e3a3ff58e9dc13a9486b17aR719 Onnx stft doesn't support centering, [and all of the existing tests are for center = False](https://github.com/pytorch/pytorch/blob/main/test/onnx/test_pytorch_onnx_onnxruntime.py#L8026). I will open a follow-up issue to address this, this is just a nice-to-have. Pr chain: - -> [Advance past fc window for stft center #145437](#145437) - [Add stft option to align window for center = false #145324](#145324) - [Add istft option to align window for center = false](#145510) Pull Request resolved: #145437 Approved by: https://github.com/justinchuby, https://github.com/iseeyuan
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #145324, also add the
align_to_windowparameter for the inverse short fourier transform op.PENDING: stft round trip tests for center = false and align_window = true
Pr chain: