[64-bit] Int64 casting for UpSampleNearest3D by jataylo · Pull Request #144865 · pytorch/pytorch

jataylo · 2025-01-15T14:48:32Z

Fixes #144855

Follows approach in #141923 to use int64 types to increase INT_MAX limits

pytorch-bot · 2025-01-15T14:48:36Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144865

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit caa9547 with merge base a08f7f3 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_torchbench_cpu_smoketest_perf, 1, 1, linux.24xl.spr-metal) (gh) (trunk failure)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

aten/src/ATen/native/cuda/UpSampleNearest3d.cu

eqy

please add a corresponding test case

jataylo · 2025-01-16T21:58:50Z

please add a corresponding test case

@eqy Yeah good idea we can steal the one from #144855

eqy · 2025-01-22T17:53:40Z

The allocation failures probably mean a largeTensorTest decorator is needed

eqy · 2025-01-23T18:56:25Z

largeTensorTest might require specialization for device e.g., cpu, cuda in this case (and those thresholds might be different)

jataylo · 2025-01-27T11:52:51Z

I need to check why I'm seeing, not observed locally. Will try with run_test locally.

2025-01-27T11:21:59.9986991Z _______________________ TestTorch.test_int64_upsample3d ________________________
2025-01-27T11:21:59.9987289Z Traceback (most recent call last):
2025-01-27T11:21:59.9987753Z   File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 3128, in wrapper
2025-01-27T11:21:59.9988203Z     method(*args, **kwargs)
2025-01-27T11:21:59.9988644Z   File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1413, in only_fn
2025-01-27T11:21:59.9989121Z     if self.device_type != slf.device_type:
2025-01-27T11:21:59.9989431Z AttributeError: 'TestTorch' object has no attribute 'device_type'
2025-01-27T11:21:59.9989659Z 
2025-01-27T11:21:59.9989795Z To execute this test, run the following from the base repo dir:
2025-01-27T11:21:59.9990203Z     PYTORCH_TEST_WITH_ROCM=1 python test/test_torch.py TestTorch.test_int64_upsample3d
2025-01-27T11:21:59.9990463Z 
2025-01-27T11:21:59.9990632Z This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
2025-01-27T11:21:59.9991196Z - generated xml file: /var/lib/jenkins/pytorch/test/test-reports/python-pytest/test_torch/test_torch-0bdb3cd908408887.xml 
```-

jataylo · 2025-01-28T15:09:10Z

Looks good now just rebasing to get rid of unrelated failures

jataylo · 2025-01-28T15:09:16Z

@pytorchbot rebase

pytorchmergebot · 2025-01-28T15:11:11Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

eqy

@pytorchmergebot merge

pytorch-bot · 2025-01-29T19:22:37Z

+1

pytorchmergebot · 2025-01-29T19:24:16Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fixes pytorch#144855 Follows approach in pytorch#141923 to use int64 types to increase INT_MAX limits Pull Request resolved: pytorch#144865 Approved by: https://github.com/eqy (cherry picked from commit 082fab0)

…orch#144865) (#1869) Fixes pytorch#144855 Follows approach in pytorch#141923 to use int64 types to increase INT_MAX limits Pull Request resolved: pytorch#144865 Approved by: https://github.com/eqy (cherry picked from commit 082fab0)

…orch#144865) (#1869) Fixes pytorch#144855 Follows approach in pytorch#141923 to use int64 types to increase INT_MAX limits Pull Request resolved: pytorch#144865 Approved by: https://github.com/eqy (cherry picked from commit 082fab0) (cherry picked from commit 5d01868)

jataylo requested a review from malfet January 15, 2025 14:48

pytorch-bot bot added the release notes: cuda release notes category label Jan 15, 2025

jataylo changed the title ~~Int64 casting for UpSampleNearest3d.cu~~ [64-bit] Int64 casting for UpSampleNearest3D Jan 15, 2025

Skylion007 reviewed Jan 15, 2025

View reviewed changes

aten/src/ATen/native/cuda/UpSampleNearest3d.cu Outdated Show resolved Hide resolved

Skylion007 reviewed Jan 15, 2025

View reviewed changes

aten/src/ATen/native/cuda/UpSampleNearest3d.cu Outdated Show resolved Hide resolved

Skylion007 reviewed Jan 15, 2025

View reviewed changes

aten/src/ATen/native/cuda/UpSampleNearest3d.cu Outdated Show resolved Hide resolved

Skylion007 requested a review from ngimel January 15, 2025 14:50

pytorchbot added the open source label Jan 15, 2025

jataylo added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/slow ciflow/rocm Trigger "default" config CI on ROCm labels Jan 16, 2025

jataylo marked this pull request as ready for review January 16, 2025 13:05

jataylo requested review from eqy and syed-ahmed as code owners January 16, 2025 13:05

eqy approved these changes Jan 16, 2025

View reviewed changes

pruthvistony requested review from jeffdaily, jithunnair-amd and pruthvistony January 20, 2025 18:08

jataylo marked this pull request as draft January 22, 2025 10:07

jataylo and others added 2 commits January 28, 2025 15:11

Int64 casting for UpSampleNearest3d.cu

237592f

Update error message

ce7b075

pytorchmergebot force-pushed the int64_upsample_3d branch from 70289c0 to caa9547 Compare January 28, 2025 15:11

pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 15:43 Inactive

pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 15:44 Inactive

pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 15:46 Inactive

jataylo marked this pull request as ready for review January 29, 2025 10:24

jataylo requested a review from Skylion007 January 29, 2025 10:25

eqy reviewed Jan 29, 2025

View reviewed changes

pytorchmergebot added the merging label Jan 29, 2025

pytorchmergebot added the Merged label Jan 29, 2025

pytorchmergebot closed this in 082fab0 Jan 29, 2025

pytorchmergebot removed the merging label Jan 29, 2025

jataylo mentioned this pull request Jan 31, 2025

[SWDEV-509031] [CP] [64-bit] Int64 casting for UpSampleNearest3D (#144865) ROCm/pytorch#1869

Merged

Conversation

jataylo commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144865

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eqy left a comment

Choose a reason for hiding this comment

Uh oh!

jataylo commented Jan 16, 2025

Uh oh!

eqy commented Jan 22, 2025

Uh oh!

eqy commented Jan 23, 2025

Uh oh!

jataylo commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jataylo commented Jan 28, 2025

Uh oh!

jataylo commented Jan 28, 2025

Uh oh!

pytorchmergebot commented Jan 28, 2025

Uh oh!

eqy left a comment

Choose a reason for hiding this comment

Uh oh!

pytorch-bot bot commented Jan 29, 2025

Uh oh!

pytorchmergebot commented Jan 29, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jataylo commented Jan 15, 2025 •

edited

Loading

pytorch-bot bot commented Jan 15, 2025 •

edited

Loading

jataylo commented Jan 27, 2025 •

edited

Loading