torchgen: support exception boundary for ExecuTorch functions#144341
Closed
swolchok wants to merge 5 commits into
Closed
torchgen: support exception boundary for ExecuTorch functions#144341swolchok wants to merge 5 commits into
swolchok wants to merge 5 commits into
Conversation
Needed for ExecuTorch diff D67904052. Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144341
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 4eeb6f3 with merge base 8cc6f17 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67906411 |
…ons" Needed for ExecuTorch diff D67904052. Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 7, 2025
Pull Request resolved: #144341 Needed for ExecuTorch diff D67904052. Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/) ghstack-source-id: 260530126
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67906411 |
…ons" Needed for ExecuTorch diff D67904052. Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 7, 2025
Pull Request resolved: #144341 Needed for ExecuTorch diff D67904052. ghstack-source-id: 260556147 Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67906411 |
…ons" Needed for ExecuTorch diff D67904052. Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 9, 2025
Pull Request resolved: #144341 Needed for ExecuTorch diff D67904052. ghstack-source-id: 260813260 Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67906411 |
Contributor
|
This passes the smell test, but it's been a while since I've looked at this code cc: @larryliu0820 who is will be more familiar |
Jack-Khuu
approved these changes
Jan 15, 2025
…ons" Needed for ExecuTorch diff D67904052. Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67906411 |
swolchok
added a commit
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: #144341 Needed for ExecuTorch diff D67904052. ghstack-source-id: 263858638 Differential Revision: [D67906411](https://our.internmc.facebook.com/intern/diff/D67906411/)
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Needed for ExecuTorch diff D67904052.
Differential Revision: D67906411