[ca] dedup node names when AOT bwd graph is reused multiple times#144202
Closed
xmfan wants to merge 2 commits intogh/xmfan/151/basefrom
Closed
[ca] dedup node names when AOT bwd graph is reused multiple times#144202xmfan wants to merge 2 commits intogh/xmfan/151/basefrom
xmfan wants to merge 2 commits intogh/xmfan/151/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144202
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ad878c3 with merge base 0431d47 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bdhirsh
reviewed
Jan 7, 2025
| raise StopIteration | ||
|
|
||
| ca_node.name = f"aot{aot_id}_{aot_node.name}" | ||
| ca_node.name = f"aot{aot_id}{aot_id_postfix}_{aot_node.name}" |
Collaborator
There was a problem hiding this comment.
tiny nit but it might be clearer to put the "_" in this fstring instead of prefixing it directly in aot_id_postfix above
bdhirsh
approved these changes
Jan 7, 2025
jansel
approved these changes
Jan 7, 2025
Member
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
aostrowski-hbn
pushed a commit
to HabanaAI/pytorch-fork
that referenced
this pull request
May 21, 2025
Cherry-pick: pytorch#144202 Change-Id: I9f6eb8ff7b1ba601149186939d2666d0a23e1bb0
jedrzejmyrcha
pushed a commit
to HabanaAI/pytorch-fork
that referenced
this pull request
Jul 29, 2025
Cherry-pick: pytorch#144202 Change-Id: I9f6eb8ff7b1ba601149186939d2666d0a23e1bb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error started popping up in HUD CA benchmarks:
We added CA initial capture's renaming (#133148) to help debug issues with AOT backward, but it errors out when we have multiple instances of the same AOT backward. This likely only showed up now because of increased hierarchical graph reuse. I fix it by adding a postfix counter to the node name
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov