Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143979
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 52dea10 with merge base 33a1996 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi, @malfet Here’s a gentle ping: we have fixed some code errors detected by the CI. When you have time, could you please take a look and provide any suggestions? |
b02c8e9 to
db6cd9f
Compare
|
@Skylion007 Could you help review it if you have time? |
|
@zhangfeiv0 Do you mind changing it to opt-in only for now and delete binary wheels workflow? Let's see if builds are passing first and than we can take next steps. |
|
@pytorchbot rebase |
|
Unknown label
|
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
db6cd9f to
a95b721
Compare
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Making some changes to the workflow now. If it finished build in reasonable amount of time, than yes, it could be landed as an opt-in for now |
|
@zhangfeiv0, you'll need to adapt your PR to make it work with CI build, i.e. docker for CI is build using files in |
ec23188 to
4c8a8c9
Compare
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
52f21d0 to
0ebe723
Compare
Signed-off-by: Zhang fei <zhangfei@iscas.ac.cn>
0ebe723 to
52dea10
Compare
malfet
left a comment
There was a problem hiding this comment.
LGTM, thank you for all the updates
|
@pytorchbot merge -f "This is opt-in CI PR, and lint is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hi, @malfet Based on the previous discussion: [RISCV CI support · Issue #141550 · pytorch/pytorch](#141550) I have cross-compiled PyTorch for the RISC-V architecture on x86_64 Ubuntu 24.04 and created a new PR for it. Could you please help review it? Pull Request resolved: #143979 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Hi, @malfet Based on the previous discussion: [RISCV CI support · Issue #141550 · pytorch/pytorch](#141550) I have cross-compiled PyTorch for the RISC-V architecture on x86_64 Ubuntu 24.04 and created a new PR for it. Could you please help review it? Pull Request resolved: #143979 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Hi, @malfet Based on the previous discussion: [RISCV CI support · Issue pytorch#141550 · pytorch/pytorch](pytorch#141550) I have cross-compiled PyTorch for the RISC-V architecture on x86_64 Ubuntu 24.04 and created a new PR for it. Could you please help review it? Pull Request resolved: pytorch#143979 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Hi, @malfet Based on the previous discussion: [RISCV CI support · Issue pytorch#141550 · pytorch/pytorch](pytorch#141550) I have cross-compiled PyTorch for the RISC-V architecture on x86_64 Ubuntu 24.04 and created a new PR for it. Could you please help review it? Pull Request resolved: pytorch#143979 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Hi, @malfet
Based on the previous discussion:
RISCV CI support · Issue #141550 · pytorch/pytorch
I have cross-compiled PyTorch for the RISC-V architecture on x86_64 Ubuntu 24.04 and created a new PR for it. Could you please help review it?
cc @malfet @seemethere