Linux Wheels: Remove triton dependency python < 3.13 constraint#143162
Closed
atalman wants to merge 1 commit into
Closed
Linux Wheels: Remove triton dependency python < 3.13 constraint#143162atalman wants to merge 1 commit into
atalman wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143162
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 559e3f4 with merge base 9f5ebf3 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
37 tasks
kit1980
approved these changes
Dec 13, 2024
Collaborator
Author
|
@pytorchmergebot merge -f "lint is green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Author
|
@pytorchbot cherry-pick --onto release/2.6 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Dec 13, 2024
) We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271 Hence constraint is no longer needed. This stack enabled torch.compile for Python 3.13 : #141264 Pull Request resolved: #143162 Approved by: https://github.com/kit1980 (cherry picked from commit 04bb82f)
Collaborator
Cherry picking #143162The cherry pick PR is at #143199 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
malfet
pushed a commit
that referenced
this pull request
Dec 13, 2024
) Linux Wheels: Remove triton dependency python < 3.13 constraint (#143162) We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271 Hence constraint is no longer needed. This stack enabled torch.compile for Python 3.13 : #141264 Pull Request resolved: #143162 Approved by: https://github.com/kit1980 (cherry picked from commit 04bb82f) Co-authored-by: Andrey Talman <atalman@fb.com>
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 13, 2024
Follow up after #143162 Pull Request resolved: #143207 Approved by: https://github.com/atalman, https://github.com/ZainRizvi
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 14, 2024
Follow up after #143162 Include triton only for 3.13 packages not 3.13t Pull Request resolved: #143218 Approved by: https://github.com/kit1980
pytorchbot
pushed a commit
that referenced
this pull request
Dec 14, 2024
Follow up after #143162 Pull Request resolved: #143207 Approved by: https://github.com/atalman, https://github.com/ZainRizvi (cherry picked from commit 625b4ed)
pytorchbot
pushed a commit
that referenced
this pull request
Dec 14, 2024
Follow up after #143162 Include triton only for 3.13 packages not 3.13t Pull Request resolved: #143218 Approved by: https://github.com/kit1980 (cherry picked from commit 3bfdf6f)
atalman
pushed a commit
that referenced
this pull request
Dec 16, 2024
[CD] Test torch.compile on 3.13 (#143207) Follow up after #143162 Pull Request resolved: #143207 Approved by: https://github.com/atalman, https://github.com/ZainRizvi (cherry picked from commit 625b4ed) Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
atalman
added a commit
that referenced
this pull request
Dec 16, 2024
Exclude py 31.3t triton package from PyTorch 3.13t wheel (#143218) Follow up after #143162 Include triton only for 3.13 packages not 3.13t Pull Request resolved: #143218 Approved by: https://github.com/kit1980 (cherry picked from commit 3bfdf6f) Co-authored-by: atalman <atalman@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271
Hence constraint is no longer needed.
This stack enabled torch.compile for Python 3.13 : #141264