Skip to content

Update inductor jobs to use CUDA 12.4#142177

Closed
huydhn wants to merge 6 commits into
pytorch:mainfrom
huydhn:cleanup-inductor-124
Closed

Update inductor jobs to use CUDA 12.4#142177
huydhn wants to merge 6 commits into
pytorch:mainfrom
huydhn:cleanup-inductor-124

Conversation

@huydhn

@huydhn huydhn commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

CUDA 12.4 is the default now. This frees up some resources. This also fixes newly added Python 3.13 job by #140733. That PR missed adding the new Docker image pytorch-linux-focal-cuda12.4-cudnn9-py3.13-gcc9-inductor-benchmarks into docker build workflow.

@huydhn huydhn requested review from atalman and malfet December 5, 2024 22:09
@huydhn huydhn requested a review from a team as a code owner December 5, 2024 22:09
@pytorch-bot

pytorch-bot Bot commented Dec 5, 2024

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142177

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2c8c4a7 with merge base 16ea0dd (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Dec 5, 2024
Comment thread .github/workflows/inductor-unittest.yml
Comment thread .github/workflows/docker-builds.yml Outdated
Comment thread .github/workflows/_linux-build.yml Outdated
malfet pushed a commit to pytorch/test-infra that referenced this pull request Dec 6, 2024
This is a short-term mitigation for
pytorch/pytorch#141885 in which any changes
touching `.ci/docker` would cause all the builds to fail until docker
build workflow finishes building the images.

At the moment, we don't have a good way to tell the build workflow to
wait for the new docker image, so my fix here attempts to inject a delay
when the action is called by `_linux_build`. It will wait up to 90
minutes for the Docker build to finish

### Testing 

pytorch/pytorch#142177
@netlify

netlify Bot commented Dec 6, 2024

Copy link
Copy Markdown

Deploy Preview for chimerical-cranachan-793287 ready!

Name Link
🔨 Latest commit 2c8c4a7
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-cranachan-793287/deploys/6753786685a3940008a0cfbe
😎 Deploy Preview https://deploy-preview-142177--chimerical-cranachan-793287.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atalman atalman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

@huydhn

huydhn commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

@pytorchbot merge -f 'Inductor jobs have passed'

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn deleted the cleanup-inductor-124 branch February 26, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants