Skip to content

[aotd] capture rrelu_with_noise noise mutation in compile#141867

Closed
IvanKobzarev wants to merge 4 commits intogh/IvanKobzarev/87/basefrom
gh/IvanKobzarev/87/head
Closed

[aotd] capture rrelu_with_noise noise mutation in compile#141867
IvanKobzarev wants to merge 4 commits intogh/IvanKobzarev/87/basefrom
gh/IvanKobzarev/87/head

Conversation

@IvanKobzarev
Copy link
Copy Markdown
Contributor

@IvanKobzarev IvanKobzarev commented Dec 2, 2024

Stack from ghstack (oldest at bottom):

Rebase-copy of long standing already approved PR #138503 that was blocked on landing by xla build issues.

Got a new PR with the same content (ghstack checkout was failing due to changed submodules)

Corresponding xla PR:
pytorch/xla#8363

cc @ezyang @gchanan @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Dec 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141867

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit dfbcc7f with merge base 9990b47 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Rebase-copy of long standing already approved PR #138503 that was blocked on landing by xla build issues.


Got a new  PR with the same content.



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 2, 2024

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

Rebase-copy of long standing already approved PR #138503 that was blocked on landing by xla build issues.


Got a new  PR with the same content (ghstack checkout was failing due to changed submodules)



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
IvanKobzarev added a commit that referenced this pull request Dec 2, 2024
@albanD albanD removed their request for review December 2, 2024 18:59
@zou3519 zou3519 removed their request for review December 2, 2024 19:40
Rebase-copy of long standing already approved PR #138503 that was blocked on landing by xla build issues.


Got a new  PR with the same content (ghstack checkout was failing due to changed submodules)

Corresponding xla PR:
pytorch/xla#8363

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
IvanKobzarev added a commit that referenced this pull request Dec 3, 2024
@IvanKobzarev
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 3, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@IvanKobzarev
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@IvanKobzarev
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…1867)

Rebase-copy of long standing already approved PR pytorch#138503 that was blocked on landing by xla build issues.

Got a new  PR with the same content (ghstack checkout was failing due to changed submodules)

Corresponding xla PR:
pytorch/xla#8363

Pull Request resolved: pytorch#141867
Approved by: https://github.com/bdhirsh
@bdhirsh bdhirsh added the module: bc-breaking Related to a BC-breaking change label Dec 5, 2024
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
…1867)

Rebase-copy of long standing already approved PR pytorch#138503 that was blocked on landing by xla build issues.

Got a new  PR with the same content (ghstack checkout was failing due to changed submodules)

Corresponding xla PR:
pytorch/xla#8363

Pull Request resolved: pytorch#141867
Approved by: https://github.com/bdhirsh
@github-actions github-actions Bot deleted the gh/IvanKobzarev/87/head branch January 5, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change module: inductor release notes: releng release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants