Skip to content

Migrate micro benchmark results to benchmark database schema v3#141745

Closed
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:migrate-llm-benchmark-results-v3
Closed

Migrate micro benchmark results to benchmark database schema v3#141745
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:migrate-llm-benchmark-results-v3

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Nov 28, 2024

Similar to #141087, this uploads the micro benchmark results to benchmark database with its new schema v3. The data can then be queried.

I'm testing with inductor-micro-benchmark-x86 which should be sufficient because inductor-micro-benchmark is broken atm. The CSV output stays for now until the dashboard is migrated to schema v3. #141747 has been resolved, so inductor-micro-benchmark should work now

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141745

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9057b59 with merge base 45ed7c1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Dec 2, 2024

@pytorchbot merge -f 'No need to run trunk jobs'

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…rch#141745)

Similar to pytorch#141087, this uploads the micro benchmark results to benchmark database with its new schema v3. The data can then be queried.

~I'm testing with `inductor-micro-benchmark-x86` which should be sufficient because `inductor-micro-benchmark` is broken atm.  The CSV output stays for now until the dashboard is migrated to schema v3.~ pytorch#141747 has been resolved, so inductor-micro-benchmark should work now

Pull Request resolved: pytorch#141745
Approved by: https://github.com/yanboliang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants