DNM - PR to test new magma images#141584
Closed
afrittoli wants to merge 1 commit into
Closed
Conversation
This is a test PR to validate the images produced by installing magma from tarball (instead of conda), introduced by pytorch#140417 Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141584
Note: Links to docs will display an error until the docs builds have been completed. ❌ 22 New Failures, 8 Unrelated FailuresAs of commit 8529c0f with merge base 313c1b3 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
@afrittoli looks like test is successful. I do see required workflow passing: https://github.com/pytorch/pytorch/actions/runs/12036252777/job/33563374083?pr=141584 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Magma is built for specific CUDA versions and stored in the ossci-linux bucket. Install it from there rather than the deprecated conda package. There are two places where magma is installed today: - `install_conda.sh`: extract the magma package in the same exact location where conda would install it, using a dedicated `install_magma_conda.sh` script. The new script is included in the relevant Dockerfiles where CUDA+magma is needed - `install_magma.sh`: this script already uses a tarball. Use the new tarball instead of the tarball from the conda package. The format of the new tarball is compatible with the old one, so changes here are minimal:wq Fixes #140538 Test PR: #141584 Pull Request resolved: #140417 Approved by: https://github.com/atalman
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Magma is built for specific CUDA versions and stored in the ossci-linux bucket. Install it from there rather than the deprecated conda package. There are two places where magma is installed today: - `install_conda.sh`: extract the magma package in the same exact location where conda would install it, using a dedicated `install_magma_conda.sh` script. The new script is included in the relevant Dockerfiles where CUDA+magma is needed - `install_magma.sh`: this script already uses a tarball. Use the new tarball instead of the tarball from the conda package. The format of the new tarball is compatible with the old one, so changes here are minimal:wq Fixes pytorch#140538 Test PR: pytorch#141584 Pull Request resolved: pytorch#140417 Approved by: https://github.com/atalman
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Magma is built for specific CUDA versions and stored in the ossci-linux bucket. Install it from there rather than the deprecated conda package. There are two places where magma is installed today: - `install_conda.sh`: extract the magma package in the same exact location where conda would install it, using a dedicated `install_magma_conda.sh` script. The new script is included in the relevant Dockerfiles where CUDA+magma is needed - `install_magma.sh`: this script already uses a tarball. Use the new tarball instead of the tarball from the conda package. The format of the new tarball is compatible with the old one, so changes here are minimal:wq Fixes #140538 Test PR: #141584 Pull Request resolved: #140417 Approved by: https://github.com/atalman
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
Magma is built for specific CUDA versions and stored in the ossci-linux bucket. Install it from there rather than the deprecated conda package. There are two places where magma is installed today: - `install_conda.sh`: extract the magma package in the same exact location where conda would install it, using a dedicated `install_magma_conda.sh` script. The new script is included in the relevant Dockerfiles where CUDA+magma is needed - `install_magma.sh`: this script already uses a tarball. Use the new tarball instead of the tarball from the conda package. The format of the new tarball is compatible with the old one, so changes here are minimal:wq Fixes pytorch#140538 Test PR: pytorch#141584 Pull Request resolved: pytorch#140417 Approved by: https://github.com/atalman
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test PR to validate the images produced by installing magma from tarball (instead of conda), introduced by #140417
Fixes #ISSUE_NUMBER