Skip to content

Update CUDA installation script to 12.6.3#141365

Closed
tinglvv wants to merge 1 commit intopytorch:mainfrom
tinglvv:use_12.6.3
Closed

Update CUDA installation script to 12.6.3#141365
tinglvv wants to merge 1 commit intopytorch:mainfrom
tinglvv:use_12.6.3

Conversation

@tinglvv
Copy link
Copy Markdown
Collaborator

@tinglvv tinglvv commented Nov 22, 2024

related to #138440

@tinglvv tinglvv requested a review from jeffdaily as a code owner November 22, 2024 19:47
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141365

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 1 Cancelled Job

As of commit 2df5c56 with merge base 7c5c38d (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 22, 2024
atalman
atalman approved these changes Nov 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Skylion007
Copy link
Copy Markdown
Collaborator

Skylion007 commented Nov 23, 2024

@tinglvv the PIP_EXTRA installs need to be updated, and the cuda_aarch install script needs also needs to be updated.

@Skylion007 Skylion007 mentioned this pull request Nov 23, 2024
Closed
Skylion007
Skylion007 requested changes Nov 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Skylion007 Skylion007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing a lot of changes needed in the build script for AArch, and properly the pypi project and binary updates. #141433

@tinglvv
Copy link
Copy Markdown
Collaborator Author

tinglvv commented Nov 25, 2024 •
edited
Loading

@Skylion007, aarch64 builds will be moved to CUDA 12.6 in a separate PR, this PR is just to have the docker image for x86 ready, so that we can test the pypi changes in binary builds. Will prepare the pypi matrix changes once this one is merged. Thanks!

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 26, 2024
@atalman
Copy link
Copy Markdown
Contributor

atalman commented Nov 26, 2024

@pytorchmergebot merge -f "lint is green, failures are not related"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 26, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 28, 2024
@Skylion007 @pytorchmergebot
[BE]: Update 12.6 builds to CUDA 12.6.3 (#141433)
7224cd4 
Update CUDA 12.6 to Update 3 and make cusparse-lt 0.6.3? #141365 Was going to leave some comments on #141365, but though it was just faster to open a PR here.
Pull Request resolved: #141433
Approved by: https://github.com/atalman
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@tinglvv
Update CUDA installation script to 12.6.3 (pytorch#141365)
4721b8a 
related to pytorch#138440
Pull Request resolved: pytorch#141365
Approved by: https://github.com/atalman
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@Skylion007
[BE]: Update 12.6 builds to CUDA 12.6.3 (pytorch#141433)
afbfd71 
Update CUDA 12.6 to Update 3 and make cusparse-lt 0.6.3? pytorch#141365 Was going to leave some comments on pytorch#141365, but though it was just faster to open a PR here.
Pull Request resolved: pytorch#141433
Approved by: https://github.com/atalman
@atalman atalman mentioned this pull request Dec 12, 2024
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 requested changes

@atalman atalman atalman approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tinglvv @Skylion007 @atalman @pytorchmergebot @bdhirsh @pytorchbot