Skip to content

Revert "only unspecialize float during eager"#141236

Closed
ezyang wants to merge 1 commit intogh/ezyang/3003/basefrom
gh/ezyang/3003/head
Closed

Revert "only unspecialize float during eager"#141236
ezyang wants to merge 1 commit intogh/ezyang/3003/basefrom
gh/ezyang/3003/head

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Nov 21, 2024 •
edited by pytorch-bot bot
Loading

@ezyang
Update
226c4ac 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Nov 21, 2024
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141236

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit 226c4ac with merge base failed to retrieve merge base, please contact dev infra:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang mentioned this pull request Nov 21, 2024
Closed
@ezyang ezyang mentioned this pull request Nov 21, 2024
Closed
ezyang added a commit that referenced this pull request Nov 21, 2024
@ezyang
Revert "only unspecialize float during eager"
9ec983c 
This reverts commit 6c1eccaf4e8afa29064be8f0e60e9092f2898108.

ghstack-source-id: 58bc0cf
Pull Request resolved: #141236
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2024

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@bobrenjc93 bobrenjc93 closed this Nov 21, 2024
@github-actions github-actions bot deleted the gh/ezyang/3003/head branch December 22, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor module: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ezyang @bobrenjc93