Skip to content

Update torch-xpu-ops commit pin#141201

Closed
toyxu wants to merge 9 commits into
pytorch:mainfrom
toyxu:xyt/xpu_pin_r26
Closed

Update torch-xpu-ops commit pin#141201
toyxu wants to merge 9 commits into
pytorch:mainfrom
toyxu:xyt/xpu_pin_r26

Conversation

@toyxu

@toyxu toyxu commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Update the torch-xpu-ops commit to 1e32bbc, includes:

  • Improve XPU aten operator coverage
  • Support basic SparseXPU operators

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

@pytorch-bot

pytorch-bot Bot commented Nov 21, 2024

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141201

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 6602c60 with merge base 3d5fe0c (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Nov 21, 2024
@EikanWang EikanWang added the ciflow/xpu Run XPU CI tasks label Nov 21, 2024
@EikanWang EikanWang marked this pull request as draft November 21, 2024 06:04
@EikanWang EikanWang changed the title Update torch-xpu-ops commit pin [WIP] Update torch-xpu-ops commit pin Nov 21, 2024
@dvrogozh

dvrogozh commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

This PR is affected by #141268 (xpu build fails). Please, help review a fix in:

Update: there was earlier submission of PR to fix the issue. See:

@xuhancn xuhancn added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 22, 2024
@EikanWang

Copy link
Copy Markdown
Collaborator

@pytorchbot rebase

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Successfully rebased xyt/xpu_pin_r26 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xyt/xpu_pin_r26 && git pull --rebase)

@toyxu

toyxu commented Nov 25, 2024

Copy link
Copy Markdown
Contributor Author

Depend on #141466

@EikanWang

Copy link
Copy Markdown
Collaborator

@pytorchbot rebase -b main

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Successfully rebased xyt/xpu_pin_r26 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xyt/xpu_pin_r26 && git pull --rebase)

@toyxu toyxu requested a review from EikanWang November 26, 2024 09:13
@chuanqi129

Copy link
Copy Markdown
Collaborator

The only one UT failure appeared in doctests, there is an issue to track it #141705

@EikanWang EikanWang changed the title [WIP] Update torch-xpu-ops commit pin Update torch-xpu-ops commit pin Nov 28, 2024
@EikanWang EikanWang marked this pull request as ready for review November 28, 2024 01:56
@EikanWang

Copy link
Copy Markdown
Collaborator

@pytorchbot merge

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Update the torch-xpu-ops commit to [1e32bbc](intel/torch-xpu-ops@1e32bbc), includes:

- Improve XPU aten operator coverage
- Support basic `SparseXPU` operators

Pull Request resolved: pytorch#141201
Approved by: https://github.com/EikanWang, https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants