Skip to content

Skip uploading benchmark records when there is no model name#141145

Closed
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:tiny-tweak-to-skip-invalid-benchmark-records
Closed

Skip uploading benchmark records when there is no model name#141145
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:tiny-tweak-to-skip-invalid-benchmark-records

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Nov 20, 2024 •
edited by pytorch-bot bot
Loading

@huydhn huydhn requested a review from malfet November 20, 2024 18:37
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141145

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a2e37bf with merge base 4acd56e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn added the topic: not user facing topic category label Nov 20, 2024
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Nov 20, 2024

@pytorchbot merge -f "This is fine"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 20, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Nov 20, 2024
@huydhn @facebook-github-bot
Skip uploading benchmark records when there is no model name (#141145)
598f5f9 
Summary:
A small fix I just realize after pytorch/pytorch#141087.

X-link: pytorch/pytorch#141145
Approved by: https://github.com/malfet

Reviewed By: izaitsevfb

Differential Revision: D66262943

Pulled By: huydhn

fbshipit-source-id: 4ccec00d23bac753fbba3ad1a39de1569efd11f8
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@huydhn
Skip uploading benchmark records when there is no model name (pytorch…
d98c5e8 
…#141145)

A small fix I just realize after pytorch#141087.

Pull Request resolved: pytorch#141145
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huydhn @malfet @pytorchmergebot