[BE][Ez]: Reserve vector for NT GEMM Matmul#141130
Closed
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Closed
[BE][Ez]: Reserve vector for NT GEMM Matmul#141130Skylion007 wants to merge 1 commit intopytorch:mainfrom
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141130
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 3fa9708 with merge base a440a01 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
2136ede to
2767e0f
Compare
2767e0f to
e1a031f
Compare
e1a031f to
3fa9708
Compare
malfet
approved these changes
Nov 20, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
LGTM, though would be nice to add a comment, that PR is aimed at improving the perf.
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Easy fix to missing reserve calls in NT Matmul CUDA kernel to improve perf. Pull Request resolved: pytorch#141130 Approved by: https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easy fix to missing reserve calls in NT Matmul CUDA kernel to improve perf.