[ROCm] TunableOp fix for batched MM with views.#140673
Closed
naromero77amd wants to merge 3 commits intopytorch:mainfrom
Closed
[ROCm] TunableOp fix for batched MM with views.#140673naromero77amd wants to merge 3 commits intopytorch:mainfrom
naromero77amd wants to merge 3 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140673
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 4fcdc3c with merge base 2817fe8 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
approved these changes
Nov 14, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 15, 2024
Fixes pytorch#140278 Pull Request resolved: pytorch#140673 Approved by: https://github.com/jeffdaily
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Nov 15, 2024
Fixes pytorch#140278 Pull Request resolved: pytorch#140673 Approved by: https://github.com/jeffdaily
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Nov 15, 2024
Fixes pytorch#140278 Upstream PR: pytorch#140673 cc: @jeffdaily
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Nov 15, 2024
Fixes pytorch#140278 Based on PR: pytorch#140673 Note in test/linalg.py that I had to include Case #4 from upstream in addition to Case #5 to resolve the merge conflict from the cherry-pick of the upstream commit. Verified manually that test_bmm_tunableop_rocm UT passes. cc: @jeffdaily
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Fixes pytorch#140278 Pull Request resolved: pytorch#140673 Approved by: https://github.com/jeffdaily
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Mar 17, 2025
Fixes pytorch#140278 Based on PR: pytorch#140673 Note in test/linalg.py that I had to include Case #4 from upstream in addition to Case #5 to resolve the merge conflict from the cherry-pick of the upstream commit. Verified manually that test_bmm_tunableop_rocm UT passes. cc: @jeffdaily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140278
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang