Skip to content

Add missing pytorch-linux-jammy-py3.12-triton-cpu Docker image#140571

Closed
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:add-pytorch-linux-jammy-py3.12-triton-cpu
Closed

Add missing pytorch-linux-jammy-py3.12-triton-cpu Docker image#140571
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:add-pytorch-linux-jammy-py3.12-triton-cpu

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Nov 13, 2024

When investigating the burst of 429 rate limit failures from docker.io yesterday, I found out that pytorch-linux-jammy-py3.12-triton-cpu hasn't been added to docker build workflow at all. The bad effect is that the image is rebuilt on every job https://github.com/pytorch/pytorch/actions/runs/11808772774/job/32900628381

@huydhn huydhn requested a review from a team as a code owner November 13, 2024 17:50
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140571

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 2940167 with merge base 03cccaa (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 13, 2024
@huydhn
Copy link
Contributor Author

huydhn commented Nov 13, 2024

@pytorchbot merge -f 'Should be ok now as all docker build and lint jobs have passed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor Author

huydhn commented Nov 13, 2024

@pytorchbot revert -m 'Not sure why lint fails, maybe a landrace' -c weird

I will rebase and reland this

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Nov 13, 2024
#140571)"

This reverts commit 51e0996.

Reverted #140571 on behalf of https://github.com/huydhn due to Not sure why lint fails, maybe a landrace ([comment](#140571 (comment)))
@pytorchmergebot
Copy link
Collaborator

@huydhn your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 13, 2024
@huydhn huydhn removed the ci-no-td Do not run TD on this PR label Nov 13, 2024
@huydhn
Copy link
Contributor Author

huydhn commented Nov 13, 2024

@pytorchbot drci

@huydhn
Copy link
Contributor Author

huydhn commented Nov 13, 2024

@pytorchbot merge -f 'ONNX failure is real but not related to this PR, merging this to fix the rate limit issue first and I will do a forward fix after then'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…ch#140571)

When investigating the burst of 429 rate limit failures from docker.io yesterday, I found out that ` pytorch-linux-jammy-py3.12-triton-cpu` hasn't been added to docker build workflow at all.  The bad effect is that the image is rebuilt on every job https://github.com/pytorch/pytorch/actions/runs/11808772774/job/32900628381

Pull Request resolved: pytorch#140571
Approved by: https://github.com/seemethere, https://github.com/wdvr
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
pytorch#140571)"

This reverts commit 51e0996.

Reverted pytorch#140571 on behalf of https://github.com/huydhn due to Not sure why lint fails, maybe a landrace ([comment](pytorch#140571 (comment)))
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…ch#140571)

When investigating the burst of 429 rate limit failures from docker.io yesterday, I found out that ` pytorch-linux-jammy-py3.12-triton-cpu` hasn't been added to docker build workflow at all.  The bad effect is that the image is rebuilt on every job https://github.com/pytorch/pytorch/actions/runs/11808772774/job/32900628381

Pull Request resolved: pytorch#140571
Approved by: https://github.com/seemethere, https://github.com/wdvr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants