Add proper parse_tensor_constants support#140558
Closed
antoniojkim wants to merge 1 commit intopytorch:mainfrom
Closed
Add proper parse_tensor_constants support#140558antoniojkim wants to merge 1 commit intopytorch:mainfrom
antoniojkim wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140558
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 573673c with merge base a8a1e58 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
0c2734e to
b274f3c
Compare
b274f3c to
573673c
Compare
davidberard98
approved these changes
Nov 13, 2024
Contributor
davidberard98
left a comment
There was a problem hiding this comment.
Assuming tests pass, LGTM!
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Fixes pytorch#140422 Pull Request resolved: pytorch#140558 Approved by: https://github.com/davidberard98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140422
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel