Skip to content

[ONNX] Remove the contiguous patch#140428

Closed
justinchuby wants to merge 2 commits intomainfrom
justinchu/contiguous-patch
Closed

[ONNX] Remove the contiguous patch#140428
justinchuby wants to merge 2 commits intomainfrom
justinchu/contiguous-patch

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Nov 12, 2024 •
edited
Loading

Remove the contiguous patch because it is no longer needed.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140428

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 9420809 with merge base 928b8ec (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Nov 12, 2024
@justinchuby justinchuby added the module: onnx Related to torch.onnx label Nov 12, 2024
@justinchuby justinchuby marked this pull request as ready for review November 12, 2024 21:54
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 13, 2024
titaiwangms
titaiwangms approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a test guarding this? And close #136543?

@justinchuby
Copy link
Collaborator Author

justinchuby commented Nov 13, 2024

There is a test in e2e, I do remember it failing without this patch before, and succeeding now. But I am not sure if the behavior is the same for all devices etc. I am inclined to merge this for now, and revert if we hit any issues in the bench.

@justinchuby
Copy link
Collaborator Author

justinchuby commented Nov 13, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@justinchuby
[ONNX] Remove the contiguous patch (pytorch#140428)
661fd6e 
Remove the contiguous patch because it is no longer needed.
Pull Request resolved: pytorch#140428
Approved by: https://github.com/titaiwangms
@github-actions github-actions bot deleted the justinchu/contiguous-patch branch December 14, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @titaiwangms @soulitzer @pytorchbot