[dynamo] skip_guard_eval_unsafe stance for power users#140251
Closed
anijain2305 wants to merge 14 commits intogh/anijain2305/587/basefrom
Closed
[dynamo] skip_guard_eval_unsafe stance for power users#140251anijain2305 wants to merge 14 commits intogh/anijain2305/587/basefrom
anijain2305 wants to merge 14 commits intogh/anijain2305/587/basefrom
Conversation
[ghstack-poisoned]
This was referenced Nov 11, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140251
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit eb55040 with merge base f4ce9ac ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
Member
williamwen42
left a comment
There was a problem hiding this comment.
Do we expect the string stance to be "default" when skip_guard_eval_unsafe=True?
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
Contributor
Author
It can be other stances as well. But I expect |
jansel
requested changes
Nov 20, 2024
torch/_dynamo/decorators.py
Outdated
|
|
||
| def __init__(self, stance: str, force_backend=None) -> None: | ||
| def __init__( | ||
| self, stance: str, skip_guard_eval_unsafe: bool = False, force_backend=None |
Contributor
There was a problem hiding this comment.
Let's force these to be kwargs:
Suggested change
| self, stance: str, skip_guard_eval_unsafe: bool = False, force_backend=None | |
| self, stance: str, *, skip_guard_eval_unsafe: bool = False, force_backend=None |
torch/compiler/__init__.py
Outdated
|
|
||
|
|
||
| def set_stance(stance: str, force_backend=None): | ||
| def set_stance(stance: str, skip_guard_eval_unsafe=False, force_backend=None): |
Contributor
There was a problem hiding this comment.
Suggested change
| def set_stance(stance: str, skip_guard_eval_unsafe=False, force_backend=None): | |
| def set_stance(stance: str, *, skip_guard_eval_unsafe=False, force_backend=None): |
torch/csrc/dynamo/extra_state.cpp
Outdated
Comment on lines
+161
to
+163
| void* diff_guard_root_mgr = | ||
| torch::dynamo::convert_to_root_guard_manager( | ||
| cache_entry.guard_manager.attr("diff_guard_root")); |
Contributor
There was a problem hiding this comment.
How expensive is this? Could we do this without doing a Python getattr (with refcountin, etc)?
Contributor
Author
There was a problem hiding this comment.
Removed this. And added a new member to the cache_entry, which we update in lockstep with the python diff_guard_root update.
Contributor
|
Maybe we should also give |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
jansel
approved these changes
Nov 21, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Pull Request resolved: pytorch#140251 Approved by: https://github.com/jansel ghstack dependencies: pytorch#140223, pytorch#140250
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames