Conversation
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140142
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b26d162 with merge base c1c94cb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D65663063 |
|
Hmm interesting. When we land it, CI is all green. Let me maybe send a new PR. Oh because the test was disabled... |
From what I see, the test was mistakenly excluded in your original PR https://github.com/pytorch/pytorch/actions/runs/11733069629/job/32687392720#step:22:630. In other word, it wasn't run. In your relanding PR, please add cc @clee2000 |
|
@ZainRizvi Not sure if this is mentioned anywhere, but if you want to land this DK revert PR, you need to put it under your name instead of darkknight to make it pass CLA. Here is what I did in a similar PR last shift |
Summary: This diff reverts D65490202 This is causing tests to fail on open source. See distributed/test_c10d_logger.py::C10dErrorLoggerTest::test_exception_logger [GH job link](https://github.com/pytorch/pytorch/actions/runs/11736922614/job/32697709457) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/ba9645f6e51bb98b39ca8b351dd7fee786083372) Test Plan: NA Differential Revision: D65663063
5893000 to
b26d162
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: This diff reverts D65490202 This is causing tests to fail on open source. See distributed/test_c10d_logger.py::C10dErrorLoggerTest::test_exception_logger [GH job link](https://github.com/pytorch/pytorch/actions/runs/11736922614/job/32697709457) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/ba9645f6e51bb98b39ca8b351dd7fee786083372) Test Plan: NA Differential Revision: D65663063 Pull Request resolved: pytorch#140142 Approved by: https://github.com/malfet, https://github.com/huydhn
Summary:
This diff reverts D65490202
This is causing tests to fail on open source. See distributed/test_c10d_logger.py::C10dErrorLoggerTest::test_exception_logger GH job link HUD commit link
Test Plan: NA
Differential Revision: D65663063
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o