Skip to content

[CD] Build aarch64 wheels without conda#140093

Closed
malfet wants to merge 5 commits intogh/malfet/54/basefrom
gh/malfet/54/head
Closed

[CD] Build aarch64 wheels without conda#140093
malfet wants to merge 5 commits intogh/malfet/54/basefrom
gh/malfet/54/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 8, 2024

Stack from ghstack (oldest at bottom):

As manylinuxaarch64-builder already comes pre-built with all versions of python runtime

Refactor logic for setting path to DESIRED_PYTHON from manywheel/build_common into set_desired_python.sh and call it from aarch64_ci_setup.sh

In followup PRs move scons and ninja installation into base docker image

[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner November 8, 2024 03:01
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140093

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Cancelled Jobs

As of commit cfa76dc with merge base 347d134 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added topic: not user facing topic category ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Nov 8, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
malfet added a commit that referenced this pull request Nov 8, 2024
As manylinuxaarch64-builder already comes pre-built with all versions of python runtime

Refactor logic for setting path to DESIRED_PYTHON from `manywheel/build_common` into `set_desired_python.sh` and call it from aarch64_ci_setup.sh

In followup PRs move scons and ninja installation into base docker image

ghstack-source-id: 9bee7fb
Pull Request resolved: #140093
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

[ghstack-poisoned]
malfet added a commit that referenced this pull request Nov 8, 2024
As manylinuxaarch64-builder already comes pre-built with all versions of python runtime

Refactor logic for setting path to DESIRED_PYTHON from `manywheel/build_common` into `set_desired_python.sh` and call it from aarch64_ci_setup.sh

In followup PRs move scons and ninja installation into base docker image

ghstack-source-id: 5e63825
Pull Request resolved: #140093
@malfet
Copy link
Contributor Author

malfet commented Nov 8, 2024

@pytorchbot merge -f "aarch64 builds passed and still build with OpenMP"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
As manylinuxaarch64-builder already comes pre-built with all versions of python runtime

Refactor logic for setting path to DESIRED_PYTHON from `manywheel/build_common` into `set_desired_python.sh` and call it from aarch64_ci_setup.sh

In followup PRs move scons and ninja installation into base docker image
Pull Request resolved: pytorch#140093
Approved by: https://github.com/atalman
@github-actions github-actions bot deleted the gh/malfet/54/head branch December 10, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants