[dynamo] switch to get_framelocals_mapping for 3.10 and below#140037
Closed
williamwen42 wants to merge 1 commit intogh/williamwen42/159/basefrom
Closed
[dynamo] switch to get_framelocals_mapping for 3.10 and below#140037williamwen42 wants to merge 1 commit intogh/williamwen42/159/basefrom
williamwen42 wants to merge 1 commit intogh/williamwen42/159/basefrom
Conversation
[ghstack-poisoned]
This was referenced Nov 7, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140037
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 36e712e with merge base b09eb6e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jansel
approved these changes
Nov 8, 2024
Member
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…h#140037) Part of implementing pytorch#93753. Next step will be to use a lower overhead data structure over `py::dict`. Pull Request resolved: pytorch#140037 Approved by: https://github.com/jansel ghstack dependencies: pytorch#139921, pytorch#139950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Part of implementing #93753. Next step will be to use a lower overhead data structure over
py::dict.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames