[BE]: Add NT missing fp classification functions#139890
[BE]: Add NT missing fp classification functions#139890Skylion007 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139890
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe10358 with merge base 59cf4bc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
d6abe10 to
ec7644b
Compare
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
ec7644b to
bae4a52
Compare
malfet
left a comment
There was a problem hiding this comment.
LGTM, thank you for the followup
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Follow up to some issues @malfet's recent PR pointed out about missing ops pytorch#139763. Tried to mirror it to other important nearby ops. Seems like we could automate / autogen this more for generic pointwise ops like this. Pull Request resolved: pytorch#139890 Approved by: https://github.com/malfet
Follow up to some issues @malfet's recent PR pointed out about missing ops #139763. Tried to mirror it to other important nearby ops. Seems like we could automate / autogen this more for generic pointwise ops like this.
cc @cpuhrsch @jbschlosser @bhosmer @drisspg @soulitzer @davidberard98 @YuqingJ