Skip to content

Removing warning for Windows Arm64#139746

Closed
iremyux wants to merge 2 commits intopytorch:mainfrom
iremyux:dll-fix-for-arm64
Closed

Removing warning for Windows Arm64#139746
iremyux wants to merge 2 commits intopytorch:mainfrom
iremyux:dll-fix-for-arm64

Conversation

@iremyux
Copy link
Collaborator

@iremyux iremyux commented Nov 5, 2024

This PR removes the warning message on Windows on Arm64, which was triggered by an issue in one of the DLLs, to improve the user experience.

Microsoft Visual C++ Redistributable is not installed, this may lead to the DLL load failure. It can be downloaded at https://aka.ms/vs/16/release/vc_redist.x64.exe

The issue is being tracked here: https://developercommunity.visualstudio.com/t/VCRUNTIME140_1DLL-Miscompiled-for-Arm64/10781635?

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @Blackhex

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139746

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f3633aa with merge base 12d225d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bdhirsh
Copy link
Collaborator

bdhirsh commented Nov 8, 2024

tentatively ccing @malfet (feel free to re-assign)

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 8, 2024
@malfet
Copy link
Contributor

malfet commented Nov 8, 2024

tentatively ccing @malfet (feel free to re-assign)

Change is trivial, so anyone could have reviewed it :) But PR author should have fixed lint on their own...

@malfet
Copy link
Contributor

malfet commented Nov 8, 2024

@pytorchbot merge -f "Lint is green, otherwise we have no tests"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
This PR removes the warning message on Windows on Arm64, which was triggered by an issue in one of the DLLs, to improve the user experience.

`Microsoft Visual C++ Redistributable is not installed, this may lead to the DLL load failure.
                 It can be downloaded at https://aka.ms/vs/16/release/vc_redist.x64.exe`

The issue is being tracked here: https://developercommunity.visualstudio.com/t/VCRUNTIME140_1DLL-Miscompiled-for-Arm64/10781635?

Pull Request resolved: pytorch#139746
Approved by: https://github.com/malfet

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@iremyux iremyux deleted the dll-fix-for-arm64 branch March 21, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: windows Windows support for PyTorch open source release notes: build release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants