Don't set replacement if lhs is in the free symbols of the rhs#139250
Closed
bobrenjc93 wants to merge 2 commits intogh/bobrenjc93/96/basefrom
Closed
Don't set replacement if lhs is in the free symbols of the rhs#139250bobrenjc93 wants to merge 2 commits intogh/bobrenjc93/96/basefrom
bobrenjc93 wants to merge 2 commits intogh/bobrenjc93/96/basefrom
Conversation
[ghstack-poisoned]
This was referenced Oct 30, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139250
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3df682f with merge base ad637a4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
Oct 30, 2024
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Also swing this one out. This one might be good to make a mini test case, it feels like it shouldn't be too difficult to do?
… rhs" Fixes python test/dynamo/test_functions.py FunctionTests.test_is_integer when we turn off specialize float on eager: #138915 cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…ch#139250) Fixes python test/dynamo/test_functions.py FunctionTests.test_is_integer when we turn off specialize float on eager: pytorch#138915 Pull Request resolved: pytorch#139250 Approved by: https://github.com/ezyang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes python test/dynamo/test_functions.py FunctionTests.test_is_integer
when we turn off specialize float on eager: #138915
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames