Closed
Conversation
To make sure that inductor tracing rules can be used to trace numpy-2.X
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139199
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8448d78 with merge base d8f99f3 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Oct 29, 2024
Collaborator
|
Thank you so much for creating the PR! I see the newly added CI test failed. link I also saw a lot of tests were run instead of the given My understanding is that it is likely that the What do you think? |
desertfire
approved these changes
Nov 7, 2024
Contributor
Author
|
Closing in favor of #140586 which fixes the silly typo I've made |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 20, 2024
Fixes #107302 This is a clone and fix for #139199. This PR is a small step for the overall NumPy 2 support. It adds a new CI job for testing with NumPy 2 with one test file only. More tests to be fixed and added later in follow-up pull requests. Pull Request resolved: #140586 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <nshulga@meta.com>
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Fixes pytorch#107302 This is a clone and fix for pytorch#139199. This PR is a small step for the overall NumPy 2 support. It adds a new CI job for testing with NumPy 2 with one test file only. More tests to be fixed and added later in follow-up pull requests. Pull Request resolved: pytorch#140586 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <nshulga@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure that inductor tracing rules can be used to trace numpy-2.X