Skip to content

[ONNX] Use TracedONNXFunction op signature to promote inputs to tensors#138770

Closed
titaiwangms wants to merge 4 commits intopytorch:mainfrom
titaiwangms:titaiwang/traced_func_uses_op_sig
Closed

[ONNX] Use TracedONNXFunction op signature to promote inputs to tensors#138770
titaiwangms wants to merge 4 commits intopytorch:mainfrom
titaiwangms:titaiwang/traced_func_uses_op_sig

Conversation

@titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Oct 23, 2024

Previous to this PR, in torchlib TracedONNXFunction, the inputs could be python constants even if the annotation sets to TensorTypes.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138770

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 40a424b with merge base 5aadaaf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 23, 2024
justinchuby
justinchuby reviewed Oct 23, 2024
View reviewed changes
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 30, 2024
@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Nov 13, 2024

@justinchuby I totally forgot the status of this. Are we still doing this?

@justinchuby
Copy link
Collaborator

justinchuby commented Nov 13, 2024

Sure! Please feel free to merge

@justinchuby
Copy link
Collaborator

justinchuby commented Nov 13, 2024

One sec

@justinchuby
Copy link
Collaborator

justinchuby commented Nov 13, 2024

I am not sure if _process_python_sequences is safe to do in the trace level? I suppose we need to preserve some python lists?

@justinchuby
Copy link
Collaborator

justinchuby commented Nov 13, 2024

Maybe just do the constants for now? What do you think?

@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Nov 13, 2024

I will test more on this.

@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Nov 14, 2024

Maybe just do the constants for now? What do you think?

Agree. python list related properties are leveraged heavily in trace_only function. Also, _process_python_constant is sufficient to solve the symint (fx.Node) and int issue.

@titaiwangms titaiwangms added module: onnx Related to torch.onnx topic: improvements topic category labels Nov 14, 2024
@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Nov 14, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 14, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 14, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@titaiwangms
[ONNX] Use TracedONNXFunction op signature to promote inputs to tenso…
0008caf 
…rs (pytorch#138770)

Previous to this PR, in torchlib TracedONNXFunction, the inputs could be python constants even if the annotation sets to TensorTypes.
Pull Request resolved: pytorch#138770
Approved by: https://github.com/justinchuby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@titaiwangms @justinchuby @pytorchmergebot @pytorchbot @mikaylagawarecki