Disabling amp context when invoking compiler by eellison · Pull Request #138624 · pytorch/pytorch

eellison · 2024-10-22T18:44:49Z

Stack from ghstack (oldest at bottom):

-> Disabling amp context when invoking compiler #138624

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

[ghstack-poisoned]

pytorch-bot · 2024-10-22T18:44:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138624

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c558d7d with merge base 2e48788 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-py3.12-clang10 / test (default, 4, 4, linux.4xlarge) (gh) (similar failure)
'test/inductor/test_compiled_autograd.py::TestCompiledAutograd::test_multithreading_tls'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

ghstack-source-id: 7b22dc8 Pull Request resolved: #138624

torch/_functorch/_aot_autograd/jit_compile_runtime_wrappers.py

Fix for #133974 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

eellison · 2024-10-22T19:14:27Z

@pytorchbot merge

pytorchmergebot · 2024-10-22T19:16:38Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-22T19:32:49Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team

Raised by workflow job

test/inductor/test_cpu_repro.py

Fix for #133974 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

ghstack-source-id: 18b806e Pull Request resolved: #138624

eellison · 2024-10-22T20:34:51Z

@pytorchbot merge

pytorchmergebot · 2024-10-22T20:36:47Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

kit1980 · 2024-10-23T00:06:37Z

@pytorchbot cherry-pick --onto release/2.5 -c critical

Fix for #133974 Pull Request resolved: #138624 Approved by: https://github.com/bdhirsh, https://github.com/drisspg (cherry picked from commit 5942b29)

pytorchbot · 2024-10-23T00:11:01Z

Cherry picking #138624

The cherry pick PR is at #138659 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

[v2.5.1] Release Tracker #138613 (comment)

Details for Dev Infra team

Raised by workflow job

leslie-fang-intel · 2024-10-23T00:40:13Z

I think it should also fix #137762. cc @Valentine233 to verify.

Disabling amp context when invoking compiler (#138624) Fix for #133974 Pull Request resolved: #138624 Approved by: https://github.com/bdhirsh, https://github.com/drisspg (cherry picked from commit 5942b29) Co-authored-by: eellison <elias.ellison@gmail.com>

Valentine233 · 2024-10-23T01:43:32Z

I think it should also fix #137762. cc @Valentine233 to verify.

Yes, the issue is also fixed.

Fix for #133974 Pull Request resolved: #138624 Approved by: https://github.com/bdhirsh, https://github.com/drisspg

Disabling amp context when invoking compiler

1ba4e31

[ghstack-poisoned]

eellison requested a review from bdhirsh as a code owner October 22, 2024 18:44

pytorch-bot bot added ciflow/inductor module: inductor labels Oct 22, 2024

Update on "Disabling amp context when invoking compiler"

24930c2

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

eellison added a commit that referenced this pull request Oct 22, 2024

Disabling amp context when invoking compiler

0798f72

ghstack-source-id: 7b22dc8 Pull Request resolved: #138624

eellison added the topic: not user facing topic category label Oct 22, 2024

bdhirsh reviewed Oct 22, 2024

View reviewed changes

torch/_functorch/_aot_autograd/jit_compile_runtime_wrappers.py Show resolved Hide resolved

bdhirsh approved these changes Oct 22, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 22, 2024

pytorchmergebot added the merging label Oct 22, 2024

pytorchmergebot removed the merging label Oct 22, 2024

drisspg reviewed Oct 22, 2024

View reviewed changes

test/inductor/test_cpu_repro.py Show resolved Hide resolved

drisspg approved these changes Oct 22, 2024

View reviewed changes

eellison added a commit that referenced this pull request Oct 22, 2024

Disabling amp context when invoking compiler

53319db

ghstack-source-id: 18b806e Pull Request resolved: #138624

pytorchmergebot added the merging label Oct 22, 2024

drisspg mentioned this pull request Oct 22, 2024

SDPA 2.5 Issue tracking #138649

Open

pytorchmergebot added the Merged label Oct 22, 2024

pytorchmergebot closed this in 5942b29 Oct 22, 2024

pytorchmergebot removed the merging label Oct 22, 2024

pytorchbot pushed a commit that referenced this pull request Oct 23, 2024

Disabling amp context when invoking compiler (#138624)

a1e8334

Fix for #133974 Pull Request resolved: #138624 Approved by: https://github.com/bdhirsh, https://github.com/drisspg (cherry picked from commit 5942b29)

pytorchbot mentioned this pull request Oct 23, 2024

Disabling amp context when invoking compiler #138659

Merged

pytorchbot mentioned this pull request Oct 23, 2024

[v2.5.1] Release Tracker #138613

Closed

Valentine233 mentioned this pull request Oct 23, 2024

[Inductor][Training] Different meta dtype for inference and training #137762

Closed

eellison mentioned this pull request Oct 23, 2024

[2.3 dynamic shapes] backend='inductor' raised: LoweringException: AssertionError: indices must be int64, byte or bool. Got [torch.float32] #124006

Closed

bhack mentioned this pull request Oct 23, 2024

AMP guards recompilation dtype mismatch. expected Half, actual Float #128134

Closed

SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024

Disabling amp context when invoking compiler (#138624)

c133661

Fix for #133974 Pull Request resolved: #138624 Approved by: https://github.com/bdhirsh, https://github.com/drisspg

isuruf mentioned this pull request Nov 5, 2024

Disable AMP when propagating fake tensors #134583

Closed

github-actions bot deleted the gh/eellison/706/head branch November 22, 2024 02:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disabling amp context when invoking compiler#138624

Disabling amp context when invoking compiler#138624
eellison wants to merge 4 commits intogh/eellison/706/basefrom
gh/eellison/706/head

eellison commented Oct 22, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

eellison commented Oct 22, 2024

Uh oh!

pytorchmergebot commented Oct 22, 2024

Uh oh!

pytorchmergebot commented Oct 22, 2024

Uh oh!

Uh oh!

eellison commented Oct 22, 2024

Uh oh!

pytorchmergebot commented Oct 22, 2024

Uh oh!

kit1980 commented Oct 23, 2024

Uh oh!

pytorchbot commented Oct 23, 2024

Uh oh!

leslie-fang-intel commented Oct 23, 2024

Uh oh!

Valentine233 commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

eellison commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138624

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Uh oh!

eellison commented Oct 22, 2024

Uh oh!

pytorchmergebot commented Oct 22, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 22, 2024

Merge failed

Uh oh!

Uh oh!

eellison commented Oct 22, 2024

Uh oh!

pytorchmergebot commented Oct 22, 2024

Merge started

Uh oh!

kit1980 commented Oct 23, 2024

Uh oh!

pytorchbot commented Oct 23, 2024

Cherry picking #138624

Uh oh!

leslie-fang-intel commented Oct 23, 2024

Uh oh!

Valentine233 commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

eellison commented Oct 22, 2024 •

edited

Loading

pytorch-bot bot commented Oct 22, 2024 •

edited

Loading