Skip to content

Enable inductor-rocm workflow for all trunk commits AND inductor-related PRs#138623

Closed
jithunnair-amd wants to merge 6 commits intopytorch:mainfrom
ROCm:trigger_inductor_rocm_on_prs
Closed

Enable inductor-rocm workflow for all trunk commits AND inductor-related PRs#138623
jithunnair-amd wants to merge 6 commits intopytorch:mainfrom
ROCm:trigger_inductor_rocm_on_prs

Conversation

@jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Oct 22, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138623

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit c8bda27 with merge base 2dab4cc (image):

NEW FAILURES - The following jobs have failed:

  • pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge) (gh)
    ERROR: Could not find a version that satisfies the requirement torch==2.5.0.dev20240901 (from versions: 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.5.0, 2.5.1, 2.6.0.dev20240923+cpu, 2.6.0.dev20240924+cpu, 2.6.0.dev20240925+cpu, 2.6.0.dev20240927+cpu, 2.6.0.dev20240928+cpu, 2.6.0.dev20240929+cpu, 2.6.0.dev20240930+cpu, 2.6.0.dev20241001+cpu, 2.6.0.dev20241002+cpu, 2.6.0.dev20241003+cpu, 2.6.0.dev20241004+cpu, 2.6.0.dev20241005+cpu, 2.6.0.dev20241006+cpu, 2.6.0.dev20241007+cpu, 2.6.0.dev20241008+cpu, 2.6.0.dev20241009+cpu, 2.6.0.dev20241010+cpu, 2.6.0.dev20241011+cpu, 2.6.0.dev20241012+cpu, 2.6.0.dev20241013+cpu, 2.6.0.dev20241014+cpu, 2.6.0.dev20241015+cpu, 2.6.0.dev20241016+cpu, 2.6.0.dev20241017+cpu, 2.6.0.dev20241018+cpu, 2.6.0.dev20241019+cpu, 2.6.0.dev20241020+cpu, 2.6.0.dev20241021+cpu, 2.6.0.dev20241022+cpu, 2.6.0.dev20241023+cpu, 2.6.0.dev20241024+cpu, 2.6.0.dev20241025+cpu, 2.6.0.dev20241026+cpu, 2.6.0.dev20241027+cpu, 2.6.0.dev20241028+cpu, 2.6.0.dev20241029+cpu, 2.6.0.dev20241030+cpu, 2.6.0.dev20241031+cpu, 2.6.0.dev20241101+cpu, 2.6.0.dev20241102+cpu, 2.6.0.dev20241103+cpu, 2.6.0.dev20241104+cpu, 2.6.0.dev20241105+cpu, 2.6.0.dev20241106+cpu, 2.6.0.dev20241107+cpu, 2.6.0.dev20241108+cpu, 2.6.0.dev20241109+cpu, 2.6.0.dev20241111+cpu, 2.6.0.dev20241112+cpu, 2.6.0.dev20241113+cpu, 2.6.0.dev20241114+cpu, 2.6.0.dev20241115+cpu, 2.6.0.dev20241116+cpu, 2.6.0.dev20241117+cpu, 2.6.0.dev20241118+cpu, 2.6.0.dev20241119+cpu, 2.6.0.dev20241120+cpu, 2.6.0.dev20241121+cpu)
  • pull / linux-jammy-py3.9-gcc11 / test (numpy_2_x, 1, 1, lf.linux.2xlarge) (gh)
    'Test'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Oct 22, 2024
@jithunnair-amd jithunnair-amd marked this pull request as ready for review October 31, 2024 06:54
@jithunnair-amd jithunnair-amd requested a review from a team as a code owner October 31, 2024 06:54
@jithunnair-amd jithunnair-amd marked this pull request as draft October 31, 2024 06:59
@jithunnair-amd
Copy link
Collaborator Author

Tested that commit triggered inductor-rocm

@jithunnair-amd jithunnair-amd marked this pull request as ready for review October 31, 2024 07:04
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 31, 2024
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot merge -f "Fixed lint space, otherwise CI ran as expected pre-lint change"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Nov 8, 2024

@pytorchbot revert -m 'I think the link failure is legit, it complains about the wrong concurrency setting in the workflow' -c ignoredsignal

https://github.com/pytorch/pytorch/actions/runs/11745317737/job/32722467379#step:14:183

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Nov 8, 2024
…tor-related PRs (#138623)"

This reverts commit ee7c3db.

Reverted #138623 on behalf of https://github.com/huydhn due to I think the link failure is legit, it complains about the wrong concurrency setting in the workflow ([comment](#138623 (comment)))
@pytorchmergebot
Copy link
Collaborator

@jithunnair-amd your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 8, 2024
@jithunnair-amd
Copy link
Collaborator Author

Fix worked as per: https://github.com/pytorch/pytorch/actions/runs/11962833666/job/33352070792#step:14:187

@pytorchbot merge -f "Fixed lint concurrency group naming"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…ted PRs (pytorch#138623)

It should help with triaging ROCm-inductor-related breakages and surfacing them in the PRs itself.

Pull Request resolved: pytorch#138623
Approved by: https://github.com/huydhn
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…tor-related PRs (pytorch#138623)"

This reverts commit ee7c3db.

Reverted pytorch#138623 on behalf of https://github.com/huydhn due to I think the link failure is legit, it complains about the wrong concurrency setting in the workflow ([comment](pytorch#138623 (comment)))
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…ted PRs (pytorch#138623)

It should help with triaging ROCm-inductor-related breakages and surfacing them in the PRs itself.

Pull Request resolved: pytorch#138623
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/rocm Trigger "default" config CI on ROCm Merged module: inductor module: rocm AMD GPU support for Pytorch open source Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants