Use cuda 12.4 pytorch_extra_install_requirements as default#138458
Closed
atalman wants to merge 1 commit intopytorch:mainfrom
Closed
Use cuda 12.4 pytorch_extra_install_requirements as default#138458atalman wants to merge 1 commit intopytorch:mainfrom
atalman wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138458
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 4 Unrelated FailuresAs of commit 1707dfd with merge base 8f3efb8 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
reviewed
Oct 21, 2024
Collaborator
albanD
left a comment
There was a problem hiding this comment.
The fact that this changes the AMD and macos binary sounds wrong!
Contributor
Author
|
Hi @albanD this is related to poetry issue where we want to have same metadata for all wheels. Hence this is changing windows, macos, amd wheels to have same metadata as the linux wheels we publish to pypi. |
malfet
approved these changes
Oct 21, 2024
Contributor
Author
|
@pytorchmergebot merge -f "XPU failures are not related" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
Author
|
@pytorchbot cherry-pick -c critical --onto release/2.5 |
Collaborator
Cherry picking #138458Command Details for Dev Infra teamRaised by workflow job |
SamGinzburg
pushed a commit
that referenced
this pull request
Oct 28, 2024
Since cuda 12.4 binaries are default binaries on pypi now. The pytorch_extra_install_requirements need to use 12.4. This would need to be cherry-picked to release 2.5 branch to avoid injecting these versions into metadata during pypi promotion. Pull Request resolved: #138458 Approved by: https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since cuda 12.4 binaries are default binaries on pypi now. The pytorch_extra_install_requirements need to use 12.4.
This would need to be cherry-picked to release 2.5 branch to avoid injecting these versions into metadata during pypi promotion.